net/data/verify_certificate_chain_unittest/target-unknown-critical-extension.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-unknown-critical-extension.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem ('k') | net/data/verify_certificate_chain_unittest/target-wrong-signature.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-unknown-critical-extension.py]	1 [Created by: generate-target-unknown-critical-extension.py]

2	2

3 Certificate chain with 1 intermediate and a trusted root. The target	3 Certificate chain with 1 intermediate and a trusted root. The target

4 certificate has an unknown X.509v3 extension (OID=1.2.3.4) that is marked as	4 certificate has an unknown X.509v3 extension (OID=1.2.3.4) that is marked as

5 critical. Verifying this certificate chain is expected to fail because there is	5 critical. Verifying this certificate chain is expected to fail because there is

6 an unrecognized critical extension.	6 an unrecognized critical extension.

7	7

8 Certificate:	8 Certificate:

9 Data:	9 Data:

10 Version: 3 (0x2)	10 Version: 3 (0x2)

(...skipping 267 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
278 150302120000Z	278 150302120000Z

279 -----BEGIN TIME-----	279 -----BEGIN TIME-----

280 MTUwMzAyMTIwMDAwWg==	280 MTUwMzAyMTIwMDAwWg==

281 -----END TIME-----	281 -----END TIME-----

282	282

283 FAIL	283 FAIL

284 -----BEGIN VERIFY_RESULT-----	284 -----BEGIN VERIFY_RESULT-----

285 RkFJTA==	285 RkFJTA==

286 -----END VERIFY_RESULT-----	286 -----END VERIFY_RESULT-----

287	287

288 [Context] Processing Certificate	288 ----- Certificate i=0 (CN=Target) -----

289 index: 1	289 ERROR: Unconsumed critical extension

290 [Error] Unconsumed critical extension	290 oid: 2A0304

291 oid: 2A0304	291 value: 01020304

292 value: 01020304	292

293	293

294 -----BEGIN ERRORS-----	294 -----BEGIN ERRORS-----

295 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIFVu Y29uc3VtZWQgY3JpdGljYWwgZXh0ZW5zaW9uCiAgICAgICAgb2lkOiAyQTAzMDQKICAgICAgICB2YWx1 ZTogMDEwMjAzMDQK	295 LS0tLS0gQ2VydGlmaWNhdGUgaT0wIChDTj1UYXJnZXQpIC0tLS0tCkVSUk9SOiBVbmNvbnN1bWVkIGNy aXRpY2FsIGV4dGVuc2lvbgogIG9pZDogMkEwMzA0CiAgdmFsdWU6IDAxMDIwMzA0Cgo=

296 -----END ERRORS-----	296 -----END ERRORS-----

OLD	NEW