net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem ('k') | net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-signed-by-512bit-rsa.py]	1 [Created by: generate-target-signed-by-512bit-rsa.py]

2	2

3 Certificate chain with 1 intermediate and a trusted root. The target	3 Certificate chain with 1 intermediate and a trusted root. The target

4 certificate is signed using a weak RSA key (512-bit modulus), and so	4 certificate is signed using a weak RSA key (512-bit modulus), and so

5 verification is expected to fail.	5 verification is expected to fail.

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 231 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
242 150302120000Z	242 150302120000Z

243 -----BEGIN TIME-----	243 -----BEGIN TIME-----

244 MTUwMzAyMTIwMDAwWg==	244 MTUwMzAyMTIwMDAwWg==

245 -----END TIME-----	245 -----END TIME-----

246	246

247 FAIL	247 FAIL

248 -----BEGIN VERIFY_RESULT-----	248 -----BEGIN VERIFY_RESULT-----

249 RkFJTA==	249 RkFJTA==

250 -----END VERIFY_RESULT-----	250 -----END VERIFY_RESULT-----

251	251

252 [Context] Processing Certificate	252 ----- Certificate i=0 (CN=Target) -----

253 index: 1	253 ERROR: RSA modulus too small

254 [Error] RSA modulus too small	254 actual: 512

255 actual: 512	255 minimum: 1024

256 minimum: 1024	256 ERROR: Unacceptable modulus length for RSA key

257 [Error] Unacceptable modulus length for RSA key	257 ERROR: VerifySignedData failed

258 [Error] VerifySignedData failed	258

259	259

260 -----BEGIN ERRORS-----	260 -----BEGIN ERRORS-----

261 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIFJT QSBtb2R1bHVzIHRvbyBzbWFsbAogICAgICAgIGFjdHVhbDogNTEyCiAgICAgICAgbWluaW11bTogMTAy NAogICAgICBbRXJyb3JdIFVuYWNjZXB0YWJsZSBtb2R1bHVzIGxlbmd0aCBmb3IgUlNBIGtleQogICAg ICBbRXJyb3JdIFZlcmlmeVNpZ25lZERhdGEgZmFpbGVkCg==	261 LS0tLS0gQ2VydGlmaWNhdGUgaT0wIChDTj1UYXJnZXQpIC0tLS0tCkVSUk9SOiBSU0EgbW9kdWx1cyB0 b28gc21hbGwKICBhY3R1YWw6IDUxMgogIG1pbmltdW06IDEwMjQKRVJST1I6IFVuYWNjZXB0YWJsZSBt b2R1bHVzIGxlbmd0aCBmb3IgUlNBIGtleQpFUlJPUjogVmVyaWZ5U2lnbmVkRGF0YSBmYWlsZWQKCg==

262 -----END ERRORS-----	262 -----END ERRORS-----

OLD	NEW