net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem ('k') | net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-has-pathlen-but-not-ca.py]	1 [Created by: generate-target-has-pathlen-but-not-ca.py]

2	2

3 Certificate chain with 1 intermediate, a trusted root, and a target	3 Certificate chain with 1 intermediate, a trusted root, and a target

4 certificate that is not a CA, and yet has a pathlen set. Verification is	4 certificate that is not a CA, and yet has a pathlen set. Verification is

5 expected to fail, since pathlen should only be set for CAs.	5 expected to fail, since pathlen should only be set for CAs.

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 266 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
277 150302120000Z	277 150302120000Z

278 -----BEGIN TIME-----	278 -----BEGIN TIME-----

279 MTUwMzAyMTIwMDAwWg==	279 MTUwMzAyMTIwMDAwWg==

280 -----END TIME-----	280 -----END TIME-----

281	281

282 FAIL	282 FAIL

283 -----BEGIN VERIFY_RESULT-----	283 -----BEGIN VERIFY_RESULT-----

284 RkFJTA==	284 RkFJTA==

285 -----END VERIFY_RESULT-----	285 -----END VERIFY_RESULT-----

286	286

287 [Context] Processing Certificate	287 ----- Certificate i=0 (CN=Target) -----

288 index: 1	288 ERROR: Target certificate looks like a CA but does not set all CA properties

289 [Error] Target certificate looks like a CA but does not set all CA propert ies	289

290	290

291 -----BEGIN ERRORS-----	291 -----BEGIN ERRORS-----

292 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIFRh cmdldCBjZXJ0aWZpY2F0ZSBsb29rcyBsaWtlIGEgQ0EgYnV0IGRvZXMgbm90IHNldCBhbGwgQ0EgcHJv cGVydGllcwo=	292 LS0tLS0gQ2VydGlmaWNhdGUgaT0wIChDTj1UYXJnZXQpIC0tLS0tCkVSUk9SOiBUYXJnZXQgY2VydGlm aWNhdGUgbG9va3MgbGlrZSBhIENBIGJ1dCBkb2VzIG5vdCBzZXQgYWxsIENBIHByb3BlcnRpZXMKCg==

293 -----END ERRORS-----	293 -----END ERRORS-----

OLD	NEW