net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/rebase-errors.py ('k') | net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-target-has-keycertsign-but-not-ca.py]	1 [Created by: generate-target-has-keycertsign-but-not-ca.py]

2	2

3 Certificate chain with 1 intermediate, a trusted root, and a target	3 Certificate chain with 1 intermediate, a trusted root, and a target

4 certificate that is not a CA, and yet has the keyCertSign bit set. Verification	4 certificate that is not a CA, and yet has the keyCertSign bit set. Verification

5 is expected to fail, since keyCertSign should only be asserted when CA is	5 is expected to fail, since keyCertSign should only be asserted when CA is

6 true.	6 true.

7	7

8 Certificate:	8 Certificate:

9 Data:	9 Data:

10 Version: 3 (0x2)	10 Version: 3 (0x2)

(...skipping 265 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
276 150302120000Z	276 150302120000Z

277 -----BEGIN TIME-----	277 -----BEGIN TIME-----

278 MTUwMzAyMTIwMDAwWg==	278 MTUwMzAyMTIwMDAwWg==

279 -----END TIME-----	279 -----END TIME-----

280	280

281 FAIL	281 FAIL

282 -----BEGIN VERIFY_RESULT-----	282 -----BEGIN VERIFY_RESULT-----

283 RkFJTA==	283 RkFJTA==

284 -----END VERIFY_RESULT-----	284 -----END VERIFY_RESULT-----

285	285

286 [Context] Processing Certificate	286 ----- Certificate i=0 (CN=Target) -----

287 index: 1	287 ERROR: Target certificate looks like a CA but does not set all CA properties

288 [Error] Target certificate looks like a CA but does not set all CA propert ies	288

289	289

290 -----BEGIN ERRORS-----	290 -----BEGIN ERRORS-----

291 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMQogICAgICBbRXJyb3JdIFRh cmdldCBjZXJ0aWZpY2F0ZSBsb29rcyBsaWtlIGEgQ0EgYnV0IGRvZXMgbm90IHNldCBhbGwgQ0EgcHJv cGVydGllcwo=	291 LS0tLS0gQ2VydGlmaWNhdGUgaT0wIChDTj1UYXJnZXQpIC0tLS0tCkVSUk9SOiBUYXJnZXQgY2VydGlm aWNhdGUgbG9va3MgbGlrZSBhIENBIGJ1dCBkb2VzIG5vdCBzZXQgYWxsIENBIHByb3BlcnRpZXMKCg==

292 -----END ERRORS-----	292 -----END ERRORS-----

OLD	NEW