net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-ca-false.pem ('k') | net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [Created by: generate-intermediate-lacks-basic-constraints.py]	1 [Created by: generate-intermediate-lacks-basic-constraints.py]

2	2

3 Certificate chain with 1 intermediate and a trusted root. The intermediate	3 Certificate chain with 1 intermediate and a trusted root. The intermediate

4 lacks the basic constraints extension, and hence is expected to fail validation	4 lacks the basic constraints extension, and hence is expected to fail validation

5 (RFC 5280 requires v3 signing certificates have a BasicConstaints).	5 (RFC 5280 requires v3 signing certificates have a BasicConstaints).

6	6

7 Certificate:	7 Certificate:

8 Data:	8 Data:

9 Version: 3 (0x2)	9 Version: 3 (0x2)

10 Serial Number: 1 (0x1)	10 Serial Number: 1 (0x1)

(...skipping 261 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
272 150302120000Z	272 150302120000Z

273 -----BEGIN TIME-----	273 -----BEGIN TIME-----

274 MTUwMzAyMTIwMDAwWg==	274 MTUwMzAyMTIwMDAwWg==

275 -----END TIME-----	275 -----END TIME-----

276	276

277 FAIL	277 FAIL

278 -----BEGIN VERIFY_RESULT-----	278 -----BEGIN VERIFY_RESULT-----

279 RkFJTA==	279 RkFJTA==

280 -----END VERIFY_RESULT-----	280 -----END VERIFY_RESULT-----

281	281

282 [Context] Processing Certificate	282 ----- Certificate i=1 (CN=Intermediate) -----

283 index: 0	283 ERROR: Does not have Basic Constraints

284 [Error] Does not have Basic Constraints	284

285	285

286 -----BEGIN ERRORS-----	286 -----BEGIN ERRORS-----

287 W0NvbnRleHRdIFByb2Nlc3NpbmcgQ2VydGlmaWNhdGUKICBpbmRleDogMAogICAgICBbRXJyb3JdIERv ZXMgbm90IGhhdmUgQmFzaWMgQ29uc3RyYWludHMK	287 LS0tLS0gQ2VydGlmaWNhdGUgaT0xIChDTj1JbnRlcm1lZGlhdGUpIC0tLS0tCkVSUk9SOiBEb2VzIG5v dCBoYXZlIEJhc2ljIENvbnN0cmFpbnRzCgo=

288 -----END ERRORS-----	288 -----END ERRORS-----

OLD	NEW