net/data/parse_certificate_unittest/cert_empty_sequence.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/cert_empty_sequence.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 This is an empty SEQUENCE. It will fail to be parsed as a Certificate since it	1 This is an empty SEQUENCE. It will fail to be parsed as a Certificate since it

2 contains no fields.	2 contains no fields.

3	3

4	4

5 $ openssl asn1parse -i < [CERTIFICATE]	5 $ openssl asn1parse -i < [CERTIFICATE]

6 0:d=0 hl=2 l= 0 cons: SEQUENCE	6 0:d=0 hl=2 l= 0 cons: SEQUENCE

7 -----BEGIN CERTIFICATE-----	7 -----BEGIN CERTIFICATE-----

8 MAA=	8 MAA=

9 -----END CERTIFICATE-----	9 -----END CERTIFICATE-----

10	10

11 [Error] Couldn't read tbsCertificate as SEQUENCE	11 ERROR: Couldn't read tbsCertificate as SEQUENCE

12	12

13 -----BEGIN ERRORS-----	13 -----BEGIN ERRORS-----

14 W0Vycm9yXSBDb3VsZG4ndCByZWFkIHRic0NlcnRpZmljYXRlIGFzIFNFUVVFTkNFCg==	14 RVJST1I6IENvdWxkbid0IHJlYWQgdGJzQ2VydGlmaWNhdGUgYXMgU0VRVUVOQ0UK

15 -----END ERRORS-----	15 -----END ERRORS-----

OLD	NEW