net/data/parse_certificate_unittest/cert_data_after_signature.pem - Issue 2759023002: Improvements to the net/cert/internal error handling.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/cert_data_after_signature.pem

Issue 2759023002: Improvements to the net/cert/internal error handling. (Closed)

Patch Set: fix comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 This is an otherwise "valid" input to ParseCertificate(), however there is a	1 This is an otherwise "valid" input to ParseCertificate(), however there is a

2 trailing NULL after the signature field.	2 trailing NULL after the signature field.

3	3

4	4

5 $ openssl asn1parse -i < [CERTIFICATE]	5 $ openssl asn1parse -i < [CERTIFICATE]

6 0:d=0 hl=2 l= 14 cons: SEQUENCE	6 0:d=0 hl=2 l= 14 cons: SEQUENCE

7 2:d=1 hl=2 l= 2 cons: SEQUENCE	7 2:d=1 hl=2 l= 2 cons: SEQUENCE

8 4:d=2 hl=2 l= 0 prim: NULL	8 4:d=2 hl=2 l= 0 prim: NULL

9 6:d=1 hl=2 l= 2 cons: SEQUENCE	9 6:d=1 hl=2 l= 2 cons: SEQUENCE

10 8:d=2 hl=2 l= 0 prim: NULL	10 8:d=2 hl=2 l= 0 prim: NULL

11 10:d=1 hl=2 l= 2 prim: BIT STRING	11 10:d=1 hl=2 l= 2 prim: BIT STRING

12 14:d=1 hl=2 l= 0 prim: NULL	12 14:d=1 hl=2 l= 0 prim: NULL

13 -----BEGIN CERTIFICATE-----	13 -----BEGIN CERTIFICATE-----

14 MA4wAgUAMAIFAAMCAKwFAA==	14 MA4wAgUAMAIFAAMCAKwFAA==

15 -----END CERTIFICATE-----	15 -----END CERTIFICATE-----

16	16

17 [Error] Unconsumed data inside Certificate SEQUENCE	17 ERROR: Unconsumed data inside Certificate SEQUENCE

18	18

19 -----BEGIN ERRORS-----	19 -----BEGIN ERRORS-----

20 W0Vycm9yXSBVbmNvbnN1bWVkIGRhdGEgaW5zaWRlIENlcnRpZmljYXRlIFNFUVVFTkNFCg==	20 RVJST1I6IFVuY29uc3VtZWQgZGF0YSBpbnNpZGUgQ2VydGlmaWNhdGUgU0VRVUVOQ0UK

21 -----END ERRORS-----	21 -----END ERRORS-----

OLD	NEW