Improvements to the net/cert/internal error handling.

net/cert/internal/path_builder.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_INTERNAL_PATH_BUILDER_H_
 #define NET_CERT_INTERNAL_PATH_BUILDER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 29 matching lines @@
   ~CertPath();
 
   scoped_refptr<TrustAnchor> trust_anchor;
 
   // Path in the forward direction (path[0] is the target cert).
   ParsedCertificateList certs;
 
   // Resets the path to empty path (same as if default constructed).
   void Clear();
 
-  // Returns true if the path is empty.
+  // TODO(eroman): Can we remove this? Unclear on how this relates to validity.
   bool IsEmpty() const;
 };
 
 // Checks whether a certificate is trusted by building candidate paths to trust
 // anchors and verifying those paths according to RFC 5280. Each instance of
 // CertPathBuilder is used for a single verification.
 //
 // WARNING: This implementation is currently experimental.  Consult an OWNER
 // before using it.
 class NET_EXPORT CertPathBuilder {
  public:
   // Represents a single candidate path that was built.
   struct NET_EXPORT ResultPath {
     ResultPath();
     ~ResultPath();
 
+    // Returns true if the candidate path is valid, false otherwise.
+    bool IsValid() const;
+
     // The (possibly partial) certificate path. Consumers must always test
-    // |valid| before using |path|. When |!valid| path.trust_anchor may be
-    // nullptr, and the path may be otherwise incomplete/invalid.
+    // |errors.IsValid()| before using |path|. When invalid,
+    // |path.trust_anchor| may be null, and the path may be incomplete.
     CertPath path;
 
-    // The errors/warnings from this path. Note that the list of errors is
-    // independent of whether the path was |valid| (a valid path may
-    // contain errors/warnings, and vice versa an invalid path may not have
-    // logged any errors).
-    CertErrors errors;
-
-    // True if |path| is a correct verified certificate chain.
-    bool valid = false;
+    // The errors/warnings from this path. Use |IsValid()| to determine if the
+    // path is valid.
+    CertPathErrors errors;
   };
 
   // Provides the overall result of path building. This includes the paths that
   // were attempted.
   struct NET_EXPORT Result {
     Result();
     ~Result();
 
     // Returns true if there was a valid path.
     bool HasValidPath() const;
@@ skipping 75 matching lines @@
   State next_state_;
 
   Result* out_result_;
 
   DISALLOW_COPY_AND_ASSIGN(CertPathBuilder);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_INTERNAL_PATH_BUILDER_H_