third_party/WebKit/Source/devtools/front_end/sdk/Target.js - Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Target.js

Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/Target.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js

index 174c9c9d7fe26065b7f508c53ba815ec0205bea1..c0e4ec4b77212c54a7ae83811b7c9fa4db5bf221 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/Target.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Target.js

@@ -143,7 +143,7 @@ SDK.Target = class extends Protocol.TargetBase {

if (!this._modelByConstructor.get(modelClass)) {

var capabilities = SDK.SDKModel._capabilitiesByModelClass.get(modelClass);

if (capabilities === undefined)

- throw 'Model class is not registered';

+ throw 'Model class is not registered @' + new Error().stack;

lushnikov 2017/03/20 23:50:09 `Model class '${modelClass}' is not registered @`

dgozman 2017/03/21 21:04:09 I tried that, but modelClass is a function, and do

if ((this._capabilitiesMask & capabilities) === capabilities) {

var model = new modelClass(this);

this._modelByConstructor.set(modelClass, model);