Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 this._invalidateAllItems(); 734 this._invalidateAllItems();
735 } 735 }
736 736
737 /** 737 /**
738 * @param {!Common.Event} event 738 * @param {!Common.Event} event
739 */ 739 */
740 _loadEventFired(event) { 740 _loadEventFired(event) {
741 if (!this._recording) 741 if (!this._recording)
742 return; 742 return;
743 743
744 var data = /** @type {number} */ (event.data); 744 var time = /** @type {number} */ (event.data.loadTime);
745 if (data) { 745 if (time) {
746 this._mainRequestLoadTime = data; 746 this._mainRequestLoadTime = time;
747 this._columns.addEventDividers([data], 'network-red-divider'); 747 this._columns.addEventDividers([time], 'network-red-divider');
748 } 748 }
749 } 749 }
750 750
751 /** 751 /**
752 * @param {!Common.Event} event 752 * @param {!Common.Event} event
753 */ 753 */
754 _domContentLoadedEventFired(event) { 754 _domContentLoadedEventFired(event) {
755 if (!this._recording) 755 if (!this._recording)
756 return; 756 return;
757 var data = /** @type {number} */ (event.data); 757 var data = /** @type {number} */ (event.data);
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1805 */ 1805 */
1806 Network.NetworkGroupLookupInterface = function() {}; 1806 Network.NetworkGroupLookupInterface = function() {};
1807 1807
1808 Network.NetworkGroupLookupInterface.prototype = { 1808 Network.NetworkGroupLookupInterface.prototype = {
1809 /** 1809 /**
1810 * @param {!SDK.NetworkRequest} request 1810 * @param {!SDK.NetworkRequest} request
1811 * @return {?string} 1811 * @return {?string}
1812 */ 1812 */
1813 lookup(request) {} 1813 lookup(request) {}
1814 }; 1814 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698