Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html

Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval. (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html
diff --git a/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html b/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html
index 67ec6e3c4343a667ad66e65c88bacb7c49007f48..be6b5c33f1eb4de91995bcc522ee29e901b6e57c 100644
--- a/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html
+++ b/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html
@@ -22,7 +22,7 @@ evalAndLog("event = document.createEvent('DeviceMotionEvent')");
shouldBeTrue("event.acceleration == null");
shouldBeTrue("event.accelerationIncludingGravity == null");
shouldBeTrue("event.rotationRate == null");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: {x: 0, y: 1, z: 2}, accelerationIncludingGravity: {x: 3, y: 4, z: 5}, rotationRate: {alpha: 6, beta: 7, gamma: 8}, interval: 9})");
shouldBeTrue("event.acceleration.x == 0");
@@ -60,7 +60,7 @@ evalAndLog("event = new DeviceMotionEvent('')");
shouldBeTrue("event.acceleration == null");
shouldBeTrue("event.accelerationIncludingGravity == null");
shouldBeTrue("event.rotationRate == null");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: [], accelerationIncludingGravity: [], rotationRate: [], interval: []})");
shouldBeTrue("event.acceleration.x == null");
@@ -80,13 +80,13 @@ shouldBeTrue("event.acceleration.y == null");
shouldBeTrue("event.acceleration.z == null");
shouldBeTrue("event.accelerationIncludingGravity == null");
shouldBeTrue("event.rotationRate == null");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: null, accelerationIncludingGravity: null, rotationRate: null, interval: null})");
shouldBeTrue("event.acceleration == null");
shouldBeTrue("event.accelerationIncludingGravity == null");
shouldBeTrue("event.rotationRate == null");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: {x: null, y: null, z: null}, accelerationIncludingGravity: {x: null, y: null, z: null}, rotationRate: {alpha: null, beta: null, gamma: null}, interval: null})");
shouldBeTrue("event.acceleration.x == null");
@@ -98,7 +98,7 @@ shouldBeTrue("event.accelerationIncludingGravity.z == null");
shouldBeTrue("event.rotationRate.alpha == null");
shouldBeTrue("event.rotationRate.beta == null");
shouldBeTrue("event.rotationRate.gamma == null");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: {x: null, y: null, z: 1}, accelerationIncludingGravity: {x: null, y: null, z: 2}, rotationRate: {alpha: null, beta: null, gamma: 3}, interval: null})");
shouldBeTrue("event.acceleration.x == null");
@@ -110,7 +110,7 @@ shouldBeTrue("event.accelerationIncludingGravity.z == 2");
shouldBeTrue("event.rotationRate.alpha == null");
shouldBeTrue("event.rotationRate.beta == null");
shouldBeTrue("event.rotationRate.gamma == 3");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: {x: undefined, y: undefined, z: undefined}, accelerationIncludingGravity: {x: undefined, y: undefined, z: undefined}, rotationRate: {alpha: undefined, beta: undefined, gamma: undefined}, interval: undefined})");
shouldBeTrue("event.acceleration.x == null");
@@ -122,7 +122,7 @@ shouldBeTrue("event.accelerationIncludingGravity.z == null");
shouldBeTrue("event.rotationRate.alpha == null");
shouldBeTrue("event.rotationRate.beta == null");
shouldBeTrue("event.rotationRate.gamma == null");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
evalAndLog("event = new DeviceMotionEvent('', {acceleration: {x: undefined, y: undefined, z: 1}, accelerationIncludingGravity: {x: undefined, y: undefined, z: 2}, rotationRate: {alpha: undefined, beta: undefined, gamma: 3}, interval: undefined})");
shouldBeTrue("event.acceleration.x == null");
@@ -134,7 +134,7 @@ shouldBeTrue("event.accelerationIncludingGravity.z == 2");
shouldBeTrue("event.rotationRate.alpha == null");
shouldBeTrue("event.rotationRate.beta == null");
shouldBeTrue("event.rotationRate.gamma == 3");
-shouldBeTrue("event.interval == null");
+shouldBeTrue("event.interval == 0");
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698