third_party/WebKit/LayoutTests/external/wpt/orientation-event/devicemotionevent-init-expected.txt - Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/orientation-event/devicemotionevent-init-expected.txt

Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval. (Closed)

Patch Set: Fix layout test expectations. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties-expected.txt ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h » ('j') | third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 This is a testharness.js-based test.
timvolodine 2017/03/22 17:05:27 why is this file being deleted? why is this file being deleted? Reilly Grant (use Gerrit) 2017/03/22 17:13:33 Deleting the -expected.txt file for a testharness. Show quoted text On 2017/03/22 17:05:27, timvolodine wrote: > why is this file being deleted? Deleting the -expected.txt file for a testharness.js-based test causes the test runner to simply check that all tests passed instead of comparing the output to an expected value. timvolodine 2017/03/22 18:27:26 do you mean it's not needed? if so, why was it the Show quoted text On 2017/03/22 17:13:33, Reilly Grant wrote: > On 2017/03/22 17:05:27, timvolodine wrote: > > why is this file being deleted? > > Deleting the -expected.txt file for a testharness.js-based test causes the test > runner to simply check that all tests passed instead of comparing the output to > an expected value. do you mean it's not needed? if so, why was it there in the first place? this patch does not appear to change devicemotionevent-init.html so not sure why this should be included here.. Reilly Grant (use Gerrit) 2017/03/22 18:38:03 This file is no longer needed because with this pa Show quoted text On 2017/03/22 18:27:26, timvolodine wrote: > On 2017/03/22 17:13:33, Reilly Grant wrote: > > On 2017/03/22 17:05:27, timvolodine wrote: > > > why is this file being deleted? > > > > Deleting the -expected.txt file for a testharness.js-based test causes the > test > > runner to simply check that all tests passed instead of comparing the output > to > > an expected value. > > do you mean it's not needed? if so, why was it there in the first place? > this patch does not appear to change devicemotionevent-init.html so not sure why > this should be included here.. This file is no longer needed because with this patch applied all of the tests are now passing. It was there before to encode the fact that we expected the test on line 2 to fail.
2 FAIL User created event is initialized properly with default values assert_equal s: interval must be initialized to 0 expected (number) 0 but got (object) null

3 PASS User created event is initialized properly using dictionary

4 Harness: the test ran to completion.

5

OLD	NEW