Change Skia DEPS to pull from googlesource (git)

Change Skia DEPS to pull from googlesource (git)

BUG=skia:1638
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270272

[borenet, 2014-05-09 14:12:42]

This should be unblocked now, since gclient should auto-delete and recover
third_party/skia.

Planning not to submit this until after the branch. I'll update skia_revision
before submitting so that the new git revision corresponds with the old svn
revision on DEPS, so that there's no code change.

[robertphillips, 2014-05-09 14:17:27]

https://codereview.chromium.org/275893002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/275893002/diff/1/DEPS#newcode159
DEPS:159: "src/third_party/skia":
skia_hash?

[robertphillips, 2014-05-09 14:18:18]

https://codereview.chromium.org/275893002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/275893002/diff/1/DEPS#newcode159
DEPS:159: "src/third_party/skia":
Ignore this - didn't notice the renaming above.

[borenet, 2014-05-09 14:32:44]

The patch is failing to apply on my trybot.  It looks like it's because it's
using a base revision from two days ago:
__main__.SubprocessFailed: apply_issue --root_dir src --issue 275893002
--patchset 1 --no-auth --server https://codereview.chromium.org --base_ref
ab8c365e2c1c1ecb1ebabd66859d94779d1efb18 --force --ignore_deps failed with code
1 in /mnt/scratch0/b_used/build/slave/linux/build after 3 attempts.

$ git show -s ab8c365e2c1c1ecb1ebabd66859d94779d1efb18
commit ab8c365e2c1c1ecb1ebabd66859d94779d1efb18
Author: tonyg@chromium.org
<tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Wed May 7 02:13:20 2014 +0000
...

Why would this be?

[borenet, 2014-05-09 14:51:24]

On 2014/05/09 14:32:44, borenet wrote:
> The patch is failing to apply on my trybot.  It looks like it's because it's
> using a base revision from two days ago:
> __main__.SubprocessFailed: apply_issue --root_dir src --issue 275893002
> --patchset 1 --no-auth --server https://codereview.chromium.org --base_ref
> ab8c365e2c1c1ecb1ebabd66859d94779d1efb18 --force --ignore_deps failed with
code
> 1 in /mnt/scratch0/b_used/build/slave/linux/build after 3 attempts.
> 
> $ git show -s ab8c365e2c1c1ecb1ebabd66859d94779d1efb18
> commit ab8c365e2c1c1ecb1ebabd66859d94779d1efb18
> Author: mailto:tonyg@chromium.org
> <mailto:tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
> Date:   Wed May 7 02:13:20 2014 +0000
> ...
> 
> Why would this be?

Ah, because it's using LKGR, which is old.  I manually triggered a run on the
same bot, which succeeds in both applying the patch and syncing.  Looks like the
gclient change is working:

"""
[0:01:37] _____ Conflicting directory found in
/mnt/scratch0/b_used/build/slave/linux/build/src/third_party/skia. Removing.
"""

[borenet, 2014-05-12 20:15:22]

Now that we're past the branch point, I'd like to land this tomorrow morning
(East coast).  Any objections?

[iannucci, 2014-05-13 01:18:46]

On 2014/05/12 20:15:22, borenet wrote:
> Now that we're past the branch point, I'd like to land this tomorrow morning
> (East coast).  Any objections?

No objections from me (lgtm), but I'd definitely poke the trooper/sheriff to
keep them on the lookout.

[iannucci, 2014-05-13 01:19:18]

On 2014/05/13 01:18:46, iannucci wrote:
> On 2014/05/12 20:15:22, borenet wrote:
> > Now that we're past the branch point, I'd like to land this tomorrow morning
> > (East coast).  Any objections?
> 
> No objections from me (lgtm), but I'd definitely poke the trooper/sheriff to
> keep them on the lookout.

Though, if it's 'morning' enough there may not be a sheriff/trooper for an hour
or three.

[robertphillips, 2014-05-13 12:02:56]

lgtm

[borenet, 2014-05-13 12:49:55]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-13 12:50:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/borenet@google.com/275893002/20001

[borenet, 2014-05-13 12:59:00]

+vabr +phajdan

[commit-bot: I haz the power, 2014-05-13 14:04:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-13 14:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 14:06:44]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[borenet, 2014-05-13 17:29:26]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-13 17:29:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/borenet@google.com/275893002/20001

[DaleCurtis, 2014-05-13 17:50:28]

Good luck! \o/  Thanks for your hard work.  I'll follow shortly with switching
over FFmpeg if this goes well.

[tfarina, 2014-05-13 18:23:53]

https://codereview.chromium.org/275893002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/275893002/diff/20001/DEPS#newcode49
DEPS:49: "skia_revision": "eaa674987f99687c0bfa337eaa27f00ffe3faa4b",
s/skia_revision/skia_hash? or skia_sha1?

[iannucci, 2014-05-13 18:51:42]

On 2014/05/13 18:23:53, tfarina wrote:
> https://codereview.chromium.org/275893002/diff/20001/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/275893002/diff/20001/DEPS#newcode49
> DEPS:49: "skia_revision": "eaa674987f99687c0bfa337eaa27f00ffe3faa4b",
> s/skia_revision/skia_hash? or skia_sha1?

Probably a good idea, but this is technically not incorrect
(https://www.kernel.org/pub/software/scm/git/docs/gitglossary.html#def_revision).
hash is probably better though
(https://www.kernel.org/pub/software/scm/git/docs/gitglossary.html#def_hash)

[borenet, 2014-05-13 18:52:20]

https://codereview.chromium.org/275893002/diff/20001/DEPS
File DEPS (right):

https://codereview.chromium.org/275893002/diff/20001/DEPS#newcode49
DEPS:49: "skia_revision": "eaa674987f99687c0bfa337eaa27f00ffe3faa4b",
On 2014/05/13 18:23:53, tfarina wrote:
> s/skia_revision/skia_hash? or skia_sha1?

I'd like to leave it as "skia_revision" for now, for consistency (angle_revision
and swarming_revision) and since that's what the AutoRoll bot expects.  In the
future it may make sense to rename them for clarity.

[borenet, 2014-05-13 19:37:30]

The CQ bit was unchecked by borenet@google.com

[borenet, 2014-05-13 19:37:37]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-13 19:39:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/borenet@google.com/275893002/20001

[borenet, 2014-05-13 20:56:40]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-05-13 20:57:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/borenet@google.com/275893002/40001

[commit-bot: I haz the power, 2014-05-14 00:39:24]

Change committed as 270272

[borenet, 2014-05-14 17:01:16]

On 2014/05/14 00:39:24, I haz the power (commit-bot) wrote:
> Change committed as 270272

Reverted in https://codereview.chromium.org/272003004/