Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: net/third_party/nss/ssl/sslimpl.h

Issue 27589002: Support new ChannelID extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add patch file Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/third_party/nss/ssl/sslimpl.h
diff --git a/net/third_party/nss/ssl/sslimpl.h b/net/third_party/nss/ssl/sslimpl.h
index 614eed145ecf3a35994c46b1b7cabbd141cf1b51..bc0e85c1f6351410e8bb311d99685b3c9bdb3fdb 100644
--- a/net/third_party/nss/ssl/sslimpl.h
+++ b/net/third_party/nss/ssl/sslimpl.h
@@ -698,6 +698,14 @@ struct sslSessionIDStr {
*/
NewSessionTicket sessionTicket;
SECItem srvName;
+
+ /* lastHandshakeHash contains the hash of the original, full
+ * handshake. This is either a SHA-1/MD5 combination (for TLS <
wtc 2013/11/14 00:50:56 IMPORTANT: this hash does not include the final ha
agl 2013/11/14 18:50:42 Done.
+ * 1.2) or a SHA-2 hash (for TLS 1.2). This is recorded and used
wtc 2013/11/14 00:50:56 To be future proof, we should say this is the hash
agl 2013/11/14 18:50:42 Done.
+ * only when ChannelID is negotiated as it's used to bind the
+ * ChannelID signature on the resumption handshake to the original
+ * handshake. */
+ SECItem lastHandshakeHash;
wtc 2013/11/14 00:50:56 Nit: "last" can also be interpreted to mean the in
agl 2013/11/14 18:50:42 Went with originalHandshakeHash.
} ssl3;
} u;
};

Powered by Google App Engine
This is Rietveld 408576698