Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

Issue 2758893002: Slim V8DOMConfiguration structs for attributes and accessors. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
index fb0ebae82b1dee5840ef737a69bcc7872f7c2d1f..4de7b411e33af871440a543cdce451e128dcf613 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
@@ -83,8 +83,6 @@ class CORE_EXPORT V8DOMConfiguration final {
const char* const name;
v8::AccessorNameGetterCallback getter;
v8::AccessorNameSetterCallback setter;
- v8::AccessorNameGetterCallback getterForMainWorld;
- v8::AccessorNameSetterCallback setterForMainWorld;
// TODO(vogelheim): This has to be removed too since it's only used in
// accessors.
// The accessor's 'result' is stored in a private property.
@@ -96,6 +94,8 @@ class CORE_EXPORT V8DOMConfiguration final {
unsigned propertyLocationConfiguration : 3;
// HolderCheckConfiguration
unsigned holderCheckConfiguration : 1;
+ // WorldConfiguration
+ unsigned worldConfiguration : 2;
};
static void installAttributes(v8::Isolate*,
@@ -139,8 +139,6 @@ class CORE_EXPORT V8DOMConfiguration final {
const char* const name;
v8::FunctionCallback getter;
v8::FunctionCallback setter;
- v8::FunctionCallback getterForMainWorld;
- v8::FunctionCallback setterForMainWorld;
// The accessor's 'result' is stored in a private property.
CachedAccessorCallback cachedAccessorCallback;
const WrapperTypeInfo* data;
@@ -150,6 +148,8 @@ class CORE_EXPORT V8DOMConfiguration final {
unsigned propertyLocationConfiguration : 3;
// HolderCheckConfiguration
unsigned holderCheckConfiguration : 1;
+ // WorldConfiguration
+ unsigned worldConfiguration : 2;
};
static void installAccessors(
@@ -263,9 +263,6 @@ class CORE_EXPORT V8DOMConfiguration final {
v8::Local<v8::Name> methodName(v8::Isolate* isolate) const {
return getSymbol(isolate);
}
- v8::FunctionCallback callbackForWorld(const DOMWrapperWorld&) const {
- return callback;
- }
v8::Local<v8::Symbol> (*getSymbol)(v8::Isolate*);
v8::FunctionCallback callback;
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698