Slim V8DOMConfiguration structs for attributes and accessors.

third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

 {% filter format_blink_cpp_source_code %}
 
 {% include 'copyright_block.txt' %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
@@ skipping 321 matching lines @@
 {##############################################################################}
 {% block install_attributes %}
 {% from 'attributes.cpp.tmpl' import attribute_configuration with context %}
 {% if data_attributes %}
 // Suppress warning: global constructors, because AttributeConfiguration is trivial
 // and does not depend on another global objects.
 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wglobal-constructors"
 #endif
-const V8DOMConfiguration::AttributeConfiguration {{v8_class}}Attributes[] = {
+static const V8DOMConfiguration::AttributeConfiguration {{v8_class}}Attributes[] = {
     {% for data_attribute in data_attributes %}
-    {{attribute_configuration(data_attribute)}},
+    {{attribute_configuration(data_attribute) | indent(4)}},
     {% endfor %}
 };
 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
 #pragma clang diagnostic pop
 #endif
 
 {% endif %}
 {% endblock %}
 {##############################################################################}
 {% block install_lazy_data_attributes %}
 {% from 'attributes.cpp.tmpl' import attribute_configuration with context %}
 {% if lazy_data_attributes %}
 // Suppress warning: global constructors, because AttributeConfiguration is trivial
 // and does not depend on another global objects.
 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wglobal-constructors"
 #endif
-const V8DOMConfiguration::AttributeConfiguration {{v8_class}}LazyDataAttributes[] = {
+static const V8DOMConfiguration::AttributeConfiguration {{v8_class}}LazyDataAttributes[] = {
     {% for data_attribute in lazy_data_attributes %}
-    {{attribute_configuration(data_attribute)}},
+    {{attribute_configuration(data_attribute) | indent(4)}},
     {% endfor %}
 };
 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
 #pragma clang diagnostic pop
 #endif
 
 {% endif %}
 {% endblock %}
 {##############################################################################}
 {% block install_accessors %}
 {% from 'attributes.cpp.tmpl' import attribute_configuration with context %}
 {% if accessors %}
-const V8DOMConfiguration::AccessorConfiguration {{v8_class}}Accessors[] = {
+static const V8DOMConfiguration::AccessorConfiguration {{v8_class}}Accessors[] = {
     {% for accessor in accessors %}
-    {{attribute_configuration(accessor)}},
+    {{attribute_configuration(accessor) | indent(4)}},
     {% endfor %}
 };
 
 {% endif %}
 {% endblock %}
 {##############################################################################}
 {% block install_methods %}
 {% from 'methods.cpp.tmpl' import method_configuration with context %}
 {% if methods | has_method_configuration(is_partial) %}
-const V8DOMConfiguration::MethodConfiguration {{v8_class}}Methods[] = {
+static const V8DOMConfiguration::MethodConfiguration {{v8_class}}Methods[] = {
     {% for method in methods | has_method_configuration(is_partial) %}
     {{method_configuration(method) | indent(4)}},
     {% endfor %}
 };
 
 {% endif %}
 {% endblock %}
 {% endif %}{# not is_array_buffer_or_view #}
 {##############################################################################}
 {% block named_constructor %}{% endblock %}
@@ skipping 77 matching lines @@
   {% set cross_origin_named_setter = '%s::crossOriginNamedSetter' % v8_class_or_partial if has_cross_origin_named_setter else 'nullptr' %}
   {% set cross_origin_named_enumerator = '%s::crossOriginNamedEnumerator' % v8_class_or_partial if has_cross_origin_named_enumerator else 'nullptr' %}
   {% set cross_origin_indexed_getter = '%s::crossOriginIndexedGetter' % v8_class_or_partial if has_cross_origin_indexed_getter else 'nullptr' %}
   instanceTemplate->SetAccessCheckCallbackAndHandler({{v8_class_or_partial}}::securityCheck, v8::NamedPropertyHandlerConfiguration({{cross_origin_named_getter}}, {{cross_origin_named_setter}}, nullptr, nullptr, {{cross_origin_named_enumerator}}), v8::IndexedPropertyHandlerConfiguration({{cross_origin_indexed_getter}}), v8::External::New(isolate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo)));
   {% endif %}
 
   {% for feature_name, attribute_list in runtime_enabled_attributes | groupby('runtime_enabled_feature_name') %}
   {% filter runtime_enabled(feature_name) %}
   {% for attribute in attribute_list | unique_by('name') | sort %}
   {% if attribute.is_data_type_property %}
-  const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration = {{attribute_configuration(attribute)}};
-  V8DOMConfiguration::installAttribute(isolate, world, instanceTemplate, prototypeTemplate, attribute{{attribute.name}}Configuration);
+  static const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration[] = {
+    {{attribute_configuration(attribute) | indent(2)}}
+  };
+  for (const auto& attributeConfig : attribute{{attribute.name}}Configuration)
+    V8DOMConfiguration::installAttribute(isolate, world, instanceTemplate, prototypeTemplate, attributeConfig);
   {% else %}
-  const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration = {{attribute_configuration(attribute)}};
-  V8DOMConfiguration::installAccessor(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, accessor{{attribute.name}}Configuration);
+  static const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration[] = {
+    {{attribute_configuration(attribute) | indent(2)}}
+  };
+  for (const auto& accessorConfig : accessor{{attribute.name}}Configuration)
+    V8DOMConfiguration::installAccessor(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, accessorConfig);
   {% endif %}
   {% endfor %}
   {% endfilter %}
   {% endfor %}
 
   {% if (indexed_property_getter or named_property_getter) and not is_partial %}
   // Indexed properties
   {{install_indexed_property_handler('instanceTemplate') | indent(2)}}
   {% endif %}
   {% if named_property_getter and not is_partial and not has_named_properties_object %}
@@ skipping 14 matching lines @@
   prototypeTemplate->SetIntrinsicDataProperty(v8AtomicString(isolate, "forEach"), v8::kArrayProto_forEach);
   prototypeTemplate->SetIntrinsicDataProperty(v8AtomicString(isolate, "keys"), v8::kArrayProto_keys);
   prototypeTemplate->SetIntrinsicDataProperty(v8AtomicString(isolate, "values"), v8::kArrayProto_values);
   {% endif %}
   {% endif %}
 
   {% if iterator_method %}
   {% filter exposed(iterator_method.exposed_test) %}
   {% filter runtime_enabled(iterator_method.runtime_enabled_feature_name) %}
   // Iterator (@@iterator)
-  const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{v8_class_or_partial}}::iteratorMethodCallback, 0, v8::DontEnum, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder, V8DOMConfiguration::DoNotCheckAccess };
+  static const V8DOMConfiguration::SymbolKeyedMethodConfiguration symbolKeyedIteratorConfiguration = { v8::Symbol::GetIterator, {{v8_class_or_partial}}::iteratorMethodCallback, 0, v8::DontEnum, V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder, V8DOMConfiguration::DoNotCheckAccess };
   V8DOMConfiguration::installMethod(isolate, world, prototypeTemplate, signature, symbolKeyedIteratorConfiguration);
   {% endfilter %}
   {% endfilter %}
   {% endif %}
 
   {% if interface_name == 'Location' %}
   // Symbol.toPrimitive
   // Prevent author scripts to inject Symbol.toPrimitive property into location
   // objects, also prevent the look-up of Symbol.toPrimitive through the
   // prototype chain.
@@ skipping 18 matching lines @@
   {% for method in methods | custom_registration(is_partial) %}
   {# install_custom_signature #}
   {% filter exposed(method.overloads.exposed_test_all
                     if method.overloads else method.exposed_test) %}
   {% filter runtime_enabled(method.overloads.runtime_enabled_all
                             if method.overloads else method.runtime_enabled_feature_name) %}
   {% if method.is_cross_origin %}
   {# TODO(dcheng): Currently, bindings must create a function object for each
      realm as a hack to support the incumbent realm. Remove this when Blink
      properly supports the incumbent realm. #}
-  {{install_origin_safe_method(method, '', 'instanceTemplate', 'prototypeTemplate') | indent(2)}}
+  {{install_origin_safe_method(method, 'instanceTemplate', 'prototypeTemplate') | indent(2)}}
   {% else %}
   {{install_custom_signature(method, 'instanceTemplate', 'prototypeTemplate', 'interfaceTemplate', 'signature') | indent(2)}}
   {% endif %}
   {% endfilter %}
   {% endfilter %}
   {% endfor %}
   {% endif %}
 }
 
 {% endif %}{# not is_array_buffer_or_view #}
@@ skipping 15 matching lines @@
   v8::Local<v8::FunctionTemplate> interfaceTemplate = {{v8_class}}::wrapperTypeInfo.domTemplate(isolate, world);
   v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemplate);
   ALLOW_UNUSED_LOCAL(signature);
 
   {# TODO(peria): Generate code to install constants. It depends on runtime_enabled_feaure of this interface. #}
 
   {% for feature_name, attrs in runtime_enabled_attributes | groupby('runtime_enabled_feature_name') %}
   {% filter runtime_enabled(feature_name) %}
   {% for attribute in attrs | unique_by('name') | sort %}
   {% if attribute.is_data_type_property %}
-  const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration = {{attribute_configuration(attribute)}};
-  V8DOMConfiguration::installAttribute(isolate, world, instance, prototype, attribute{{attribute.name}}Configuration);
+  static const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration[] = {
+    {{attribute_configuration(attribute) | indent(2)}}
+  };
+  for (const auto& attributeConfig : attribute{{attribute.name}}Configuration)
+    V8DOMConfiguration::installAttribute(isolate, world, instance, prototype, attributeConfig);
   {% else %}
-  const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration = {{attribute_configuration(attribute)}};
-  V8DOMConfiguration::installAccessor(isolate, world, instance, prototype, interface, signature, accessor{{attribute.name}}Configuration);
+  static const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration[] = {
+    {{attribute_configuration(attribute) | indent(2)}}
+  };
+  for (const auto& accessorConfig : accessor{{attribute.name}}Configuration)
+    V8DOMConfiguration::installAccessor(isolate, world, instance, prototype, interface, signature, accessorConfig);
   {% endif %}
   {% endfor %}
   {% endfilter %}
   {% endfor %}
 
   {% if iterator_method and iterator_method.runtime_enabled_feature_name %}
   {% filter exposed(iterator_method.exposed_test) %}
   {% filter runtime_enabled(iterator_method.runtime_enabled_feature_name) %}
   // Runtime enabled iterator (@@iterator)
 #error "{{v8_class_or_partial}} should not have runtime enabled iterators."
@@ skipping 31 matching lines @@
 {% for feature in origin_trial_features %}
 void {{v8_class_or_partial}}::install{{feature.name}}(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface) {
   {% if feature.attributes or feature.methods %}
   v8::Local<v8::FunctionTemplate> interfaceTemplate = {{v8_class}}::wrapperTypeInfo.domTemplate(isolate, world);
   v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemplate);
   ALLOW_UNUSED_LOCAL(signature);
   {% endif %}
   {# Origin-Trial-enabled attributes #}
   {% for attribute in feature.attributes %}
   {% if attribute.is_data_type_property %}
-  const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration = {{attribute_configuration(attribute)}};
-  V8DOMConfiguration::installAttribute(isolate, world, instance, prototype, attribute{{attribute.name}}Configuration);
+  static const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration[] = {
+    {{attribute_configuration(attribute) | indent(2)}}
+  };
+  for (const auto& attributeConfig : attribute{{attribute.name}}Configuration)
+    V8DOMConfiguration::installAttribute(isolate, world, instance, prototype, attributeConfig);
   {% else %}
-  const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration = {{attribute_configuration(attribute)}};
-  V8DOMConfiguration::installAccessor(isolate, world, instance, prototype, interface, signature, accessor{{attribute.name}}Configuration);
+  static const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration[] = {
+    {{attribute_configuration(attribute) | indent(2)}}
+  };
+  for (const auto& accessorConfig : accessor{{attribute.name}}Configuration)
+    V8DOMConfiguration::installAccessor(isolate, world, instance, prototype, interface, signature, accessorConfig);
   {% endif %}
   {% endfor %}
   {# Origin-Trial-enabled constants #}
   {% for constant in feature.constants %}
   {% set constant_name = constant.name.title().replace('_', '') %}
   const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Configuration = {{constant_configuration(constant)}};
   V8DOMConfiguration::installConstant(isolate, interface, prototype, constant{{constant_name}}Configuration);
   {% endfor %}
   {# Origin-Trial-enabled methods (no overloads) #}
   {% for method in feature.methods %}
   {% set method_name = method.name.title().replace('_', '') %}
-  const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configuration[] = {
+  static const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configuration[] = {
     {{method_configuration(method) | indent(2)}}
   };
   for (const auto& methodConfig : method{{method_name}}Configuration)
     V8DOMConfiguration::installMethod(isolate, world, instance, prototype, interface, signature, methodConfig);
   {% endfor %}
 }
 
 void {{v8_class_or_partial}}::install{{feature.name}}(ScriptState* scriptState, v8::Local<v8::Object> instance) {
   V8PerContextData* perContextData = V8PerContextData::from(scriptState->context());
   v8::Local<v8::Object> prototype = perContextData->prototypeForType(&{{v8_class}}::wrapperTypeInfo);
@@ skipping 56 matching lines @@
 {% endif %}
 }
 {% endif %}
 
 {% endblock %}
 {##############################################################################}
 {% block partial_interface %}{% endblock %}
 }  // namespace blink
 
 {% endfilter %}{# format_blink_cpp_source_code #}