Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 27588003: ignore buildbot_java_home value. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna
Modified:
7 years, 2 months ago
Reviewers:
dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

ignore buildbot_java_home value. BUG= R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=28756

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M client/tools/buildbot_annotated_steps.py View 1 1 chunk +1 line, -3 lines 0 comments Download
M editor/tools/compile_analyzer.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
We'll see if this helps at all. The hope is JAVA_HOME will not have a ...
7 years, 2 months ago (2013-10-16 22:00:03 UTC) #1
dgrove
lgtm
7 years, 2 months ago (2013-10-16 22:01:02 UTC) #2
dgrove
lgtm
7 years, 2 months ago (2013-10-16 22:04:13 UTC) #3
Emily Fortuna
7 years, 2 months ago (2013-10-16 22:04:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698