Throw correct errors for invalid OfflineAudioContext values

third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 41 matching lines @@
   // FIXME: add support for workers.
   if (!context || !context->isDocument()) {
     exceptionState.throwDOMException(NotSupportedError,
                                      "Workers are not supported.");
     return nullptr;
   }
 
   Document* document = toDocument(context);
 
   if (!numberOfFrames) {
-    exceptionState.throwDOMException(SyntaxError,
-                                     "number of frames cannot be zero.");
+    exceptionState.throwDOMException(
+        NotSupportedError,
+        ExceptionMessages::indexExceedsMinimumBound<unsigned>(
+            "number of frames", numberOfFrames, 1));
     return nullptr;
   }
 
-  if (numberOfChannels > BaseAudioContext::maxNumberOfChannels()) {
+  if (numberOfChannels == 0 ||
+      numberOfChannels > BaseAudioContext::maxNumberOfChannels()) {
     exceptionState.throwDOMException(
-        IndexSizeError, ExceptionMessages::indexOutsideRange<unsigned>(
-                            "number of channels", numberOfChannels, 0,
-                            ExceptionMessages::InclusiveBound,
-                            BaseAudioContext::maxNumberOfChannels(),
-                            ExceptionMessages::InclusiveBound));
+        NotSupportedError, ExceptionMessages::indexOutsideRange<unsigned>(
+                               "number of channels", numberOfChannels, 1,
+                               ExceptionMessages::InclusiveBound,
+                               BaseAudioContext::maxNumberOfChannels(),
+                               ExceptionMessages::InclusiveBound));
     return nullptr;
   }
 
   if (!AudioUtilities::isValidAudioBufferSampleRate(sampleRate)) {
     exceptionState.throwDOMException(
-        IndexSizeError, ExceptionMessages::indexOutsideRange(
-                            "sampleRate", sampleRate,
-                            AudioUtilities::minAudioBufferSampleRate(),
-                            ExceptionMessages::InclusiveBound,
-                            AudioUtilities::maxAudioBufferSampleRate(),
-                            ExceptionMessages::InclusiveBound));
+        NotSupportedError, ExceptionMessages::indexOutsideRange(
+                               "sampleRate", sampleRate,
+                               AudioUtilities::minAudioBufferSampleRate(),
+                               ExceptionMessages::InclusiveBound,
+                               AudioUtilities::maxAudioBufferSampleRate(),
+                               ExceptionMessages::InclusiveBound));
     return nullptr;
   }
 
   OfflineAudioContext* audioContext = new OfflineAudioContext(
       document, numberOfChannels, numberOfFrames, sampleRate, exceptionState);
 
   if (!audioContext->destination()) {
     exceptionState.throwDOMException(
         NotSupportedError, "OfflineAudioContext(" +
                                String::number(numberOfChannels) + ", " +
                                String::number(numberOfFrames) + ", " +
                                String::number(sampleRate) + ")");
+    return nullptr;
   }
 
 #if DEBUG_AUDIONODE_REFERENCES
   fprintf(stderr, "[%16p]: OfflineAudioContext::OfflineAudioContext()\n",
           audioContext);
 #endif
   DEFINE_STATIC_LOCAL(SparseHistogram, offlineContextChannelCountHistogram,
                       ("WebAudio.OfflineAudioContext.ChannelCount"));
   // Arbitrarly limit the maximum length to 1 million frames (about 20 sec
   // at 48kHz).  The number of buckets is fairly arbitrary.
@@ skipping 336 matching lines @@
 
   // Note that the GraphLock is required before this check. Since this needs
   // to run on the audio thread, OfflineGraphAutoLocker must be used.
   if (m_scheduledSuspends.contains(currentSampleFrame()))
     return true;
 
   return false;
 }
 
 }  // namespace blink