Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4199)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2758743002: Disable flaky tests in Chrome OS file manager. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 0771664f3139aca10e04aa9a204b9241006c9a6f..6dbef3aecf86b1b6733a8c393f3941526b2c00fa 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -309,8 +309,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
#else
#define MAYBE_ShareDialog ShareDialog
#endif
+// Flaky: crbug.com/702119.
WRAPPED_INSTANTIATE_TEST_CASE_P(
- MAYBE_ShareDialog,
+ DISABLED_ShareDialog,
FileManagerBrowserTest,
::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "shareFile"),
TestParameter(NOT_IN_GUEST_MODE, "shareDirectory")));
@@ -410,9 +411,10 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
WRAPPED_INSTANTIATE_TEST_CASE_P(
MAYBE_FolderShortcuts,
FileManagerBrowserTest,
- ::testing::Values(
- TestParameter(NOT_IN_GUEST_MODE, "traverseFolderShortcuts"),
- TestParameter(NOT_IN_GUEST_MODE, "addRemoveFolderShortcuts")));
+ ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
+ "traverseFolderShortcuts")));
+// Flaky: crbug.com/702119.
+// TestParameter(NOT_IN_GUEST_MODE, "addRemoveFolderShortcuts")));
// Fails on official build. http://crbug.com/429294
#if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
@@ -563,8 +565,9 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(
::testing::Values(
TestParameter(NOT_IN_GUEST_MODE, "requestMount"),
TestParameter(NOT_IN_GUEST_MODE, "requestMountMultipleMounts"),
- TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceDevice"),
- TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceFile")));
+ TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceDevice")));
+// Flaky: crbug.com/702119.
+// TestParameter(NOT_IN_GUEST_MODE, "requestMountSourceFile")));
#if defined(DISABLE_SLOW_FILESAPP_TESTS)
#define MAYBE_GearMenu DISABLED_GearMenu
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698