Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 275873002: Re-land "Pass RenderFrameHost to WebContentObservers' message handlers" (Closed)

Created:
6 years, 7 months ago by mnaganov (inactive)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, chromium-apps-reviews_chromium.org, stuartmorgan+watch_chromium.org, ajwong+watch_chromium.org, darin-cc_chromium.org, markusheintz_, miu+watch_chromium.org
Visibility:
Public.

Description

Re-land "Pass RenderFrameHost to WebContentObservers' message handlers" This patch enables WebContentsObserver::OnMessageReceived to receive a reference to RenderFrameHost that received the message. This allows passing of JavaBridgeDispatcherHostManager ownership from WebContentsImpl to ContentViewCore and removing of some redundant initialization code in JavaBridgeDispatcherHostManager, fixing a long-standing TODO. This patch also includes a fix for "Search Google for this image" discovered shorly after the original patch has been landed. BUG=371296 TBR=jam@chromium.org,benm@chromium.org,yoz@chromium.org,bauerb@chromium.org,fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -111 lines) Patch
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/plugin_permission_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/plugin_permission_helper.cc View 1 chunk +15 lines, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 4 chunks +9 lines, -3 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 5 chunks +25 lines, -23 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h View 3 chunks +10 lines, -12 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 5 chunks +25 lines, -27 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 4 chunks +0 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +9 lines, -14 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 4 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_observer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mnaganov (inactive)
I'm re-landing my change that had been speculatively reverted during the recent tree firefighting, with ...
6 years, 7 months ago (2014-05-09 12:39:13 UTC) #1
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 7 months ago (2014-05-09 12:39:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/275873002/1
6 years, 7 months ago (2014-05-09 12:46:14 UTC) #3
jam
lgtm
6 years, 7 months ago (2014-05-09 17:19:13 UTC) #4
commit-bot: I haz the power
Change committed as 269571
6 years, 7 months ago (2014-05-10 12:06:37 UTC) #5
Evan Stade
4 years, 5 months ago (2016-07-16 00:06:37 UTC) #6
Message was sent while issue was closed.
On 2014/05/10 12:06:37, commit-bot: I haz the power wrote:
> Change committed as 269571

this also broke InfoBarService (similar to CoreTabHelper). No one noticed this
rare infobar went missing for the last 2 years. :[ I wonder if any other
messages are getting dropped on the floor?

Powered by Google App Engine
This is Rietveld 408576698