third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc - Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutRuby.h ('K') | « third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

index a7b476f4d0a6aefdc1590f2e55431bb444b59835..80e8e66edf58a10b6aaef5ccbe3b3229b52518ef 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

@@ -77,7 +77,7 @@ WTF::Optional<LayoutUnit> GetClearanceOffset(

case EClear::kBoth:

return OptionalMax<LayoutUnit>(left_offset, right_offset);

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

return WTF::nullopt;

}