third_party/WebKit/Source/core/layout/LayoutRuby.h - Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRuby.h

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutRuby.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutRuby.h b/third_party/WebKit/Source/core/layout/LayoutRuby.h

index 0e62ff7731ea146dd8b9a29a3ca726c40f4b7ce2..1197302f475e6046ffa938753473b4cfa0bd7214 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRuby.h

+++ b/third_party/WebKit/Source/core/layout/LayoutRuby.h

@@ -96,9 +96,7 @@ class LayoutRubyAsBlock final : public LayoutBlockFlow {

return type == LayoutObjectRuby || LayoutBlockFlow::isOfType(type);

}

bool createsAnonymousWrapper() const override { return true; }

- void removeLeftoverAnonymousBlock(LayoutBlock*) override {

- ASSERT_NOT_REACHED();

- }

+ void removeLeftoverAnonymousBlock(LayoutBlock*) override { NOTREACHED(); }

eae 2017/03/17 23:37:45 Nice :)

};

} // namespace blink