Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2758683002: Replace ASSERT_NOT_REACHED with NOTREACHED in core/layout/ (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 } 454 }
455 455
456 DISABLE_CFI_PERF 456 DISABLE_CFI_PERF
457 bool LayoutBlock::updateLogicalWidthAndColumnWidth() { 457 bool LayoutBlock::updateLogicalWidthAndColumnWidth() {
458 LayoutUnit oldWidth = logicalWidth(); 458 LayoutUnit oldWidth = logicalWidth();
459 updateLogicalWidth(); 459 updateLogicalWidth();
460 return oldWidth != logicalWidth() || widthAvailableToChildrenHasChanged(); 460 return oldWidth != logicalWidth() || widthAvailableToChildrenHasChanged();
461 } 461 }
462 462
463 void LayoutBlock::layoutBlock(bool) { 463 void LayoutBlock::layoutBlock(bool) {
464 ASSERT_NOT_REACHED(); 464 NOTREACHED();
465 clearNeedsLayout(); 465 clearNeedsLayout();
466 } 466 }
467 467
468 void LayoutBlock::addOverflowFromChildren() { 468 void LayoutBlock::addOverflowFromChildren() {
469 if (childrenInline()) 469 if (childrenInline())
470 toLayoutBlockFlow(this)->addOverflowFromInlineChildren(); 470 toLayoutBlockFlow(this)->addOverflowFromInlineChildren();
471 else 471 else
472 addOverflowFromBlockChildren(); 472 addOverflowFromBlockChildren();
473 } 473 }
474 474
(...skipping 1520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1995 return child->isLayoutBlock() ? toLayoutBlock(child)->hasMarginBeforeQuirk() 1995 return child->isLayoutBlock() ? toLayoutBlock(child)->hasMarginBeforeQuirk()
1996 : child->style()->hasMarginBeforeQuirk(); 1996 : child->style()->hasMarginBeforeQuirk();
1997 1997
1998 // The child is perpendicular to us and box sides are never quirky in 1998 // The child is perpendicular to us and box sides are never quirky in
1999 // html.css, and we don't really care about whether or not authors specified 1999 // html.css, and we don't really care about whether or not authors specified
2000 // quirky ems, since they're an implementation detail. 2000 // quirky ems, since they're an implementation detail.
2001 return false; 2001 return false;
2002 } 2002 }
2003 2003
2004 const char* LayoutBlock::name() const { 2004 const char* LayoutBlock::name() const {
2005 ASSERT_NOT_REACHED(); 2005 NOTREACHED();
2006 return "LayoutBlock"; 2006 return "LayoutBlock";
2007 } 2007 }
2008 2008
2009 LayoutBlock* LayoutBlock::createAnonymousWithParentAndDisplay( 2009 LayoutBlock* LayoutBlock::createAnonymousWithParentAndDisplay(
2010 const LayoutObject* parent, 2010 const LayoutObject* parent,
2011 EDisplay display) { 2011 EDisplay display) {
2012 // FIXME: Do we need to convert all our inline displays to block-type in the 2012 // FIXME: Do we need to convert all our inline displays to block-type in the
2013 // anonymous logic ? 2013 // anonymous logic ?
2014 EDisplay newDisplay; 2014 EDisplay newDisplay;
2015 LayoutBlock* newBox = nullptr; 2015 LayoutBlock* newBox = nullptr;
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
2227 } 2227 }
2228 2228
2229 return availableHeight; 2229 return availableHeight;
2230 } 2230 }
2231 2231
2232 bool LayoutBlock::hasDefiniteLogicalHeight() const { 2232 bool LayoutBlock::hasDefiniteLogicalHeight() const {
2233 return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1); 2233 return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1);
2234 } 2234 }
2235 2235
2236 } // namespace blink 2236 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698