Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: chrome/browser/sync/test/integration/single_client_printers_sync_test.cc

Issue 2758643002: Flakiness in SingleClientPrintersSyncTest.EditPrinter (Closed)
Patch Set: all tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/printing/printers_sync_bridge.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/single_client_printers_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc b/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc
index 0f9ecd65446432e487cfff6c811ed683fd791f27..f460295fdec43be226d47ef698e8e1d4a41c87d7 100644
--- a/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc
+++ b/chrome/browser/sync/test/integration/single_client_printers_sync_test.cc
@@ -25,6 +25,14 @@ class SingleClientPrintersSyncTest : public SyncTest {
SingleClientPrintersSyncTest() : SyncTest(SINGLE_CLIENT) {}
~SingleClientPrintersSyncTest() override {}
+ bool SetupSync() override {
+ if (!SyncTest::SetupSync())
+ return false;
+
+ // Wait for sync to complete initialization before proceeding.
+ return UpdatedProgressMarkerChecker(GetSyncService(0)).Wait();
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(SingleClientPrintersSyncTest);
};
@@ -32,7 +40,6 @@ class SingleClientPrintersSyncTest : public SyncTest {
// Verify that printers aren't added with a sync call.
IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, NoPrinters) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
- ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
EXPECT_TRUE(ProfileContainsSamePrintersAsVerifier(0));
}
@@ -53,13 +60,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, SingleNewPrinter) {
}
// Verify editing a printer doesn't add it.
-// Flaky on ChromeOS. http://crbug.com/701999
-#if defined(OS_CHROMEOS)
-#define MAYBE_EditPrinter DISABLED_EditPrinter
-#else
-#define MAYBE_EditPrinter EditPrinter
-#endif
-IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, MAYBE_EditPrinter) {
+IN_PROC_BROWSER_TEST_F(SingleClientPrintersSyncTest, EditPrinter) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
AddPrinter(GetPrinterStore(0), printers_helper::CreateTestPrinter(0));
« no previous file with comments | « chrome/browser/chromeos/printing/printers_sync_bridge.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698