Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 275863005: Document Bluetooth Socket API (Closed)

Created:
6 years, 7 months ago by keybuk
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments #

Patch Set 3 : Fix refs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -30 lines) Patch
M chrome/common/extensions/docs/templates/articles/app_bluetooth.html View 1 2 11 chunks +248 lines, -30 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/intro_tables.json View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
keybuk
6 years, 7 months ago (2014-05-13 00:18:05 UTC) #1
armansito
https://codereview.chromium.org/275863005/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html File chrome/common/extensions/docs/templates/articles/app_bluetooth.html (right): https://codereview.chromium.org/275863005/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html#newcode153 chrome/common/extensions/docs/templates/articles/app_bluetooth.html:153: o you should call $(ref:bluetooth.stopDiscovery) when done. s/o you ...
6 years, 7 months ago (2014-05-13 20:24:46 UTC) #2
keybuk
https://codereview.chromium.org/275863005/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html File chrome/common/extensions/docs/templates/articles/app_bluetooth.html (right): https://codereview.chromium.org/275863005/diff/1/chrome/common/extensions/docs/templates/articles/app_bluetooth.html#newcode153 chrome/common/extensions/docs/templates/articles/app_bluetooth.html:153: o you should call $(ref:bluetooth.stopDiscovery) when done. On 2014/05/13 ...
6 years, 7 months ago (2014-05-20 18:09:14 UTC) #3
keybuk
+all other OWNERS this CL has been waiting for a review for a week! :-(
6 years, 7 months ago (2014-05-20 18:12:57 UTC) #4
not at google - send to devlin
I was planning on rubberstamping when armansito@ gives lg.
6 years, 7 months ago (2014-05-20 18:15:18 UTC) #5
armansito
lgtm
6 years, 7 months ago (2014-05-21 03:54:59 UTC) #6
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-21 15:12:23 UTC) #7
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 7 months ago (2014-05-21 16:45:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/275863005/40001
6 years, 7 months ago (2014-05-21 19:59:01 UTC) #9
keybuk
6 years, 7 months ago (2014-05-21 20:38:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r271967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698