Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Issue 2758623002: Remove SK_IGNORE_DW_GRAY_FIX (Closed)

Created:
3 years, 9 months ago by bungeman-skia
Modified:
3 years, 8 months ago
Reviewers:
drott
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_IGNORE_DW_GRAY_FIX. Before this change when the user asked Skia for anti-aliased but not subpixel anti-aliased glyphs with DirectWrite the user would always get the subpixel anti-aliased glyphs but downsampled (the three channels of subpixel alpha per pixel averaged into one channel of alpha per pixel). With the DirectWrite shipped in Windows 8 and later there is a new interface which allows Skia to obtain the single channel anti-aliased alpha directly. The primary difference from using this method is that subpixel smoothing (ClearType, aka a blur) is not applied. This provides less blurry glyphs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M skia/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bungeman-skia
This should change nothing on win7, but improve all the anti-aliased glyphs on win10.
3 years, 9 months ago (2017-03-17 22:08:58 UTC) #2
drott
On 2017/03/17 at 22:08:58, bungeman wrote: > This should change nothing on win7, but improve ...
3 years, 9 months ago (2017-03-20 09:20:29 UTC) #3
drott
3 years, 8 months ago (2017-03-29 12:10:55 UTC) #6
Message was sent while issue was closed.
Closed, landed in https://chromium-review.googlesource.com/c/459519/

Powered by Google App Engine
This is Rietveld 408576698