Enable screen capture for ARC++ Kiosk

chrome/browser/chromeos/login/arc_kiosk_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/arc_kiosk_controller.h"
 
 #include "base/bind.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h"
@@ skipping 15 matching lines @@
 
 ArcKioskController::ArcKioskController(LoginDisplayHost* host, OobeUI* oobe_ui)
     : host_(host),
       arc_kiosk_splash_screen_view_(oobe_ui->GetArcKioskSplashScreenView()),
       weak_ptr_factory_(this) {}
 
 ArcKioskController::~ArcKioskController() {
   arc_kiosk_splash_screen_view_->SetDelegate(nullptr);
 }
 
-void ArcKioskController::StartArcKiosk(const AccountId& account_id) {
+void ArcKioskController::StartArcKiosk(const AccountId& account_id,
+                                       bool is_auto_launch) {
   DVLOG(1) << "Starting ARC Kiosk for account: " << account_id.GetUserEmail();
 
   host_->GetWebUILoginView()->SetUIEnabled(true);
 
   arc_kiosk_splash_screen_view_->SetDelegate(this);
   arc_kiosk_splash_screen_view_->Show();
   splash_wait_timer_.Start(FROM_HERE, kArcKioskSplashScreenMinTime,
                            base::Bind(&ArcKioskController::CloseSplashScreen,
                                       weak_ptr_factory_.GetWeakPtr()));
 
+  if (is_auto_launch) {

[Ivan Šandrk, 2017/03/16 18:30:43]

If I rely on auto_launch_account_id_, I can skip the whole part where I wire
is_auto_launch around the code, and just set a boolean here.

+    int auto_launch_delay = -1;

[Luis Héctor Chávez, 2017/03/16 19:42:30]

nit: why not do

int auto_launch_delay = 0;
CrosSettings::Get()->GetInteger(...);

if (auto_launch_delay == 0)
  ...

?

[Ivan Šandrk, 2017/03/16 22:32:50]

I guess I was going by this code and tried replicating it (and also wanted to
add clarifying question but forgot in the meantime)
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/app_launch...

Is it true what it says there? (Kiosks do not support non-zero auto-login
delays)

+    if (!CrosSettings::Get()->GetInteger(
+            kAccountsPrefDeviceLocalAccountAutoLoginDelay,

[Luis Héctor Chávez, 2017/03/16 19:42:30]

dumb question: can you not get this from ArcKioskAppManager::UpdateApps()? That
way you can expose the launch delay from ArcKioskAppManager instead of exposing
an account id which is seems like it might drift from the value of
ArcKioskAppManager::GetAutoLaunchAccountId().

[Ivan Šandrk, 2017/03/16 22:32:49]

Good question! It did cross my mind actually, that's probably the best place to
put it. Thanks for the suggestion, I'll make the code changes tomorrow from the
office.

+            &auto_launch_delay)) {
+      auto_launch_delay = 0;
+    }
+
+    // Mark arc kiosk app launched with zero delay.
+    if (auto_launch_delay == 0)
+      ArcKioskAppManager::Get()->SetWasAutoLaunchedWithZeroDelay(account_id);
+  }
+
   login_performer_ = base::MakeUnique<ChromeLoginPerformer>(this);
   login_performer_->LoginAsArcKioskAccount(account_id);
 }
 
 void ArcKioskController::CleanUp() {
   splash_wait_timer_.Stop();
   // Delegate is registered only when |profile_| is set.
   if (profile_)
     ArcKioskAppService::Get(profile_)->SetDelegate(nullptr);
   if (host_)
@@ skipping 70 matching lines @@
   CloseSplashScreen();
 }
 
 void ArcKioskController::OnCancelArcKioskLaunch() {
   KioskAppLaunchError::Save(KioskAppLaunchError::USER_CANCEL);
   CleanUp();
   chrome::AttemptUserExit();
 }
 
 }  // namespace chromeos