Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: test/cctest/interpreter/test-interpreter.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Address comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-interpreter.cc
diff --git a/test/cctest/interpreter/test-interpreter.cc b/test/cctest/interpreter/test-interpreter.cc
index ed986bba4b03065438dd78f37ad974fb509a532c..3cad62a3601a488b70443b120b36900963a02d41 100644
--- a/test/cctest/interpreter/test-interpreter.cc
+++ b/test/cctest/interpreter/test-interpreter.cc
@@ -592,7 +592,8 @@ TEST(InterpreterBinaryOpTypeFeedback) {
{Token::Value::SUB, ast_factory.NewSmi(2), ast_factory.NewSmi(3),
Handle<Smi>(Smi::FromInt(-1), isolate),
BinaryOperationFeedback::kSignedSmall},
- {Token::Value::SUB, ast_factory.NewSmi(Smi::kMinValue),
+ {Token::Value::SUB,
+ ast_factory.NewSmi(static_cast<uint32_t>(Smi::kMinValue)),
ast_factory.NewSmi(1),
isolate->factory()->NewHeapNumber(Smi::kMinValue - 1.0),
BinaryOperationFeedback::kNumber},
@@ -610,7 +611,8 @@ TEST(InterpreterBinaryOpTypeFeedback) {
{Token::Value::MUL, ast_factory.NewSmi(2), ast_factory.NewSmi(3),
Handle<Smi>(Smi::FromInt(6), isolate),
BinaryOperationFeedback::kSignedSmall},
- {Token::Value::MUL, ast_factory.NewSmi(Smi::kMinValue),
+ {Token::Value::MUL,
+ ast_factory.NewSmi(static_cast<uint32_t>(Smi::kMinValue)),
ast_factory.NewSmi(2),
isolate->factory()->NewHeapNumber(Smi::kMinValue * 2.0),
BinaryOperationFeedback::kNumber},
@@ -645,8 +647,8 @@ TEST(InterpreterBinaryOpTypeFeedback) {
{Token::Value::MOD, ast_factory.NewSmi(5), ast_factory.NewSmi(3),
Handle<Smi>(Smi::FromInt(2), isolate),
BinaryOperationFeedback::kSignedSmall},
- {Token::Value::MOD, ast_factory.NewSmi(-4), ast_factory.NewSmi(2),
- isolate->factory()->NewHeapNumber(-0.0),
+ {Token::Value::MOD, ast_factory.NewSmi(static_cast<uint32_t>(-4)),
+ ast_factory.NewSmi(2), isolate->factory()->NewHeapNumber(-0.0),
BinaryOperationFeedback::kNumber},
{Token::Value::MOD, ast_factory.NewNumber(3.1415), ast_factory.NewSmi(3),
isolate->factory()->NewHeapNumber(fmod(3.1415, 3.0)),
@@ -723,7 +725,8 @@ TEST(InterpreterBinaryOpSmiTypeFeedback) {
{Token::Value::SUB, ast_factory.NewSmi(2), 42,
Handle<Smi>(Smi::FromInt(-40), isolate),
BinaryOperationFeedback::kSignedSmall},
- {Token::Value::SUB, ast_factory.NewSmi(Smi::kMinValue), 1,
+ {Token::Value::SUB,
+ ast_factory.NewSmi(static_cast<uint32_t>(Smi::kMinValue)), 1,
isolate->factory()->NewHeapNumber(Smi::kMinValue - 1.0),
BinaryOperationFeedback::kNumber},
{Token::Value::SUB, ast_factory.NewNumber(3.1415), 2,
« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698