src/runtime/runtime-liveedit.cc - Issue 2758563002: [gn] Enable stricter build flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-liveedit.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)

Patch Set: Fix one last unused variable error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-liveedit.cc

diff --git a/src/runtime/runtime-liveedit.cc b/src/runtime/runtime-liveedit.cc

index 56493252c8fd57cffb74977c154bb6c9e26efc30..fa49df88dada9240d42e58cc01986a8808de0b53 100644

--- a/src/runtime/runtime-liveedit.cc

+++ b/src/runtime/runtime-liveedit.cc

@@ -32,7 +32,7 @@ RUNTIME_FUNCTION(Runtime_LiveEditFindSharedFunctionInfosForScript) {

{

HeapIterator iterator(heap);

HeapObject* heap_obj;

- while ((heap_obj = iterator.next())) {

+ while ((heap_obj = iterator.next()) != nullptr) {

if (!heap_obj->IsSharedFunctionInfo()) continue;

SharedFunctionInfo* shared = SharedFunctionInfo::cast(heap_obj);

if (shared->script() != *script) continue;