Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: src/objects.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Fix one last unused variable error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 60bf5d4e85bd408352667e3ed24cfe1aa762a587..edf07fef73e62d414ec7d1c43dfba6d17957cc04 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -12351,7 +12351,7 @@ static void InvalidatePrototypeChainsInternal(Map* map) {
WeakFixedArray::Iterator iterator(proto_info->prototype_users());
// For now, only maps register themselves as users.
Map* user;
- while ((user = iterator.Next<Map>())) {
+ while ((user = iterator.Next<Map>()) != nullptr) {
// Walk the prototype chain (backwards, towards leaf objects) if necessary.
InvalidatePrototypeChainsInternal(user);
}
@@ -13333,7 +13333,7 @@ void SharedFunctionInfo::SetScript(Handle<SharedFunctionInfo> shared,
if (FLAG_enable_slow_asserts) {
WeakFixedArray::Iterator iterator(*list);
SharedFunctionInfo* next;
- while ((next = iterator.Next<SharedFunctionInfo>())) {
+ while ((next = iterator.Next<SharedFunctionInfo>()) != nullptr) {
DCHECK_NE(next, *shared);
}
}

Powered by Google App Engine
This is Rietveld 408576698