Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/heap/spaces.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Fix one last unused variable error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index f94789afc40a5874c38d9a9224748b3cdc0352e6..9b6d5a814bc3f292bbe5d9a5580e28d560169795 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -508,7 +508,7 @@ void Page::InitializeAsAnchor(Space* space) {
set_owner(space);
set_next_chunk(this);
set_prev_chunk(this);
- SetFlags(0, ~0);
+ SetFlags(0, static_cast<uintptr_t>(~0));
SetFlag(ANCHOR);
}
@@ -1637,7 +1637,7 @@ bool SemiSpace::EnsureCurrentCapacity() {
current_page->InsertAfter(anchor());
current_page->ClearLiveness();
current_page->SetFlags(anchor()->prev_page()->GetFlags(),
- Page::kCopyAllFlags);
+ static_cast<uintptr_t>(Page::kCopyAllFlags));
heap()->CreateFillerObjectAt(current_page->area_start(),
static_cast<int>(current_page->area_size()),
ClearRecordedSlots::kNo);
@@ -2094,7 +2094,8 @@ void SemiSpace::RemovePage(Page* page) {
}
void SemiSpace::PrependPage(Page* page) {
- page->SetFlags(current_page()->GetFlags(), Page::kCopyAllFlags);
+ page->SetFlags(current_page()->GetFlags(),
+ static_cast<uintptr_t>(Page::kCopyAllFlags));
page->set_owner(this);
page->InsertAfter(anchor());
pages_used_++;
« src/compiler/gap-resolver.cc ('K') | « src/heap/spaces.h ('k') | src/heap/spaces-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698