Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: src/globals.h

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Fix one last unused variable error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index 3f37141790e739a0501952c58140919f631ff238..b9790296c8386da09023951661c8f8694318ef95 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -1125,23 +1125,23 @@ inline bool IsValidFunctionKind(FunctionKind kind) {
inline bool IsArrowFunction(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kArrowFunction;
+ return (kind & FunctionKind::kArrowFunction) != 0;
}
inline bool IsGeneratorFunction(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kGeneratorFunction;
+ return (kind & FunctionKind::kGeneratorFunction) != 0;
}
inline bool IsModule(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kModule;
+ return (kind & FunctionKind::kModule) != 0;
}
inline bool IsAsyncFunction(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kAsyncFunction;
+ return (kind & FunctionKind::kAsyncFunction) != 0;
}
inline bool IsResumableFunction(FunctionKind kind) {
@@ -1150,45 +1150,45 @@ inline bool IsResumableFunction(FunctionKind kind) {
inline bool IsConciseMethod(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kConciseMethod;
+ return (kind & FunctionKind::kConciseMethod) != 0;
}
inline bool IsGetterFunction(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kGetterFunction;
+ return (kind & FunctionKind::kGetterFunction) != 0;
}
inline bool IsSetterFunction(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kSetterFunction;
+ return (kind & FunctionKind::kSetterFunction) != 0;
}
inline bool IsAccessorFunction(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kAccessorFunction;
+ return (kind & FunctionKind::kAccessorFunction) != 0;
}
inline bool IsDefaultConstructor(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kDefaultConstructor;
+ return (kind & FunctionKind::kDefaultConstructor) != 0;
}
inline bool IsBaseConstructor(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kBaseConstructor;
+ return (kind & FunctionKind::kBaseConstructor) != 0;
}
inline bool IsDerivedConstructor(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kDerivedConstructor;
+ return (kind & FunctionKind::kDerivedConstructor) != 0;
}
inline bool IsClassConstructor(FunctionKind kind) {
DCHECK(IsValidFunctionKind(kind));
- return kind & FunctionKind::kClassConstructor;
+ return (kind & FunctionKind::kClassConstructor) != 0;
}
« src/compiler/gap-resolver.cc ('K') | « src/field-index-inl.h ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698