src/extensions/statistics-extension.cc - Issue 2758563002: [gn] Enable stricter build flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/extensions/statistics-extension.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)

Patch Set: Fix one last unused variable error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/extensions/statistics-extension.cc

diff --git a/src/extensions/statistics-extension.cc b/src/extensions/statistics-extension.cc

index ad412975cf489e4b62eb68ed3cd73825e8a19cff..3e49c527e30028035e096555446fcebb2a54aaf8 100644

--- a/src/extensions/statistics-extension.cc

+++ b/src/extensions/statistics-extension.cc

@@ -144,7 +144,7 @@ void StatisticsExtension::GetCounters(

HeapObject* obj;

int reloc_info_total = 0;

int source_position_table_total = 0;

- while ((obj = iterator.next())) {

+ while ((obj = iterator.next()) != nullptr) {

if (obj->IsCode()) {

Code* code = Code::cast(obj);

reloc_info_total += code->relocation_info()->Size();