Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/api.cc

Issue 2758563002: [gn] Enable stricter build flags (Closed)
Patch Set: Fix one last unused variable error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gni/v8.gni ('k') | src/ast/context-slot-cache.h » ('j') | src/compiler/gap-resolver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 9337708dcf0f7b3985b580c2208edde485fc88e5..e976f7478d8b7a8018cfc4105bd57d5ed3cf5a3f 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -9405,7 +9405,7 @@ void debug::GetLoadedScripts(v8::Isolate* v8_isolate,
i::DisallowHeapAllocation no_gc;
i::Script::Iterator iterator(isolate);
i::Script* script;
- while ((script = iterator.Next())) {
+ while ((script = iterator.Next()) != nullptr) {
if (!script->IsUserJavaScript()) continue;
if (script->HasValidSource()) {
i::HandleScope handle_scope(isolate);
« no previous file with comments | « gni/v8.gni ('k') | src/ast/context-slot-cache.h » ('j') | src/compiler/gap-resolver.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698