Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 275853002: Revert of Wires up view manager to an actual display (Closed)

Created:
6 years, 7 months ago by Paweł Hajdan Jr.
Modified:
6 years, 7 months ago
CC:
chromium-reviews, ben+aura_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, sadrul, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Revert of Wires up view manager to an actual display (https://codereview.chromium.org/267293004/) Reason for revert: Broke runhooks, http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20195/steps/runhooks/logs/stdio This is a trivial typo, but I have only limited cycles. Original issue's description: > Wires up view manager to an actual display > > Adds a SetViewContents to exercise this. > > BUG=365012 > TEST=none > R=ben@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269206 TBR=ben@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -578 lines) Patch
M mojo/mojo.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_services.gypi View 5 chunks +3 lines, -34 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 chunk +1 line, -5 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_unittests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/services/view_manager/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/services/view_manager/main.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M mojo/services/view_manager/node.h View 4 chunks +1 line, -26 lines 0 comments Download
M mojo/services/view_manager/node.cc View 3 chunks +3 lines, -71 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 7 chunks +15 lines, -21 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 4 chunks +16 lines, -15 lines 0 comments Download
D mojo/services/view_manager/root_view_manager.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/services/view_manager/root_view_manager.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M mojo/services/view_manager/view.h View 3 chunks +0 lines, -5 lines 0 comments Download
M mojo/services/view_manager/view.cc View 1 chunk +0 lines, -8 lines 0 comments Download
A mojo/services/view_manager/view_manager.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M mojo/shell/context.cc View 2 chunks +31 lines, -1 line 0 comments Download
D mojo/shell/view_manager_loader.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/shell/view_manager_loader.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Created Revert of Wires up view manager to an actual display
6 years, 7 months ago (2014-05-09 10:38:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/275853002/1
6 years, 7 months ago (2014-05-09 10:42:05 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 10:47:09 UTC) #3
Message was sent while issue was closed.
Change committed as 269212

Powered by Google App Engine
This is Rietveld 408576698