Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: test/inspector/protocol-test.js

Issue 2758483002: [debugger] tuned StepNext and StepOut at return position (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/inspector/protocol-test.js
diff --git a/test/inspector/protocol-test.js b/test/inspector/protocol-test.js
index 1808387ae532c602a7cd216ac79928042bff0936..db3cdee013b77889d08d7a6bfa7648cae6706cc5 100644
--- a/test/inspector/protocol-test.js
+++ b/test/inspector/protocol-test.js
@@ -7,6 +7,7 @@ InspectorTest._dispatchTable = new Map();
InspectorTest._requestId = 0;
InspectorTest._dumpInspectorProtocolMessages = false;
InspectorTest._eventHandler = {};
+InspectorTest._commandToLog = new Set();
dgozman 2017/03/21 23:33:21 _commandsForLogging
kozy 2017/03/22 17:09:45 Done.
Protocol = new Proxy({}, {
get: function(target, agentName, receiver) {
@@ -30,6 +31,8 @@ Protocol = new Proxy({}, {
}
});
+InspectorTest.dumpProtocolCommand = (command) => InspectorTest._commandToLog.add(command);
dgozman 2017/03/21 23:33:21 logProtocolCommandCalls
kozy 2017/03/22 17:09:46 Done.
+
var utils = {};
(function setupUtils() {
utils.load = load;
@@ -265,6 +268,9 @@ InspectorTest._sendCommandPromise = function(method, params, contextGroupId)
var messageObject = { "id": requestId, "method": method, "params": params };
var fulfillCallback;
var promise = new Promise(fulfill => fulfillCallback = fulfill);
+ if (InspectorTest._commandToLog.has(method)) {
+ utils.print(method + ' called');
+ }
InspectorTest.sendRawCommand(requestId, JSON.stringify(messageObject), fulfillCallback, contextGroupId);
return promise;
}

Powered by Google App Engine
This is Rietveld 408576698