src/runtime/runtime-debug.cc - Issue 2758483002: [debugger] tuned StepNext and StepOut at return position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 2758483002: [debugger] tuned StepNext and StepOut at return position (Closed)

Patch Set: addressed comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 0d555e60320a9cd1d341148ca8ddf16de69aa367..fe3783d5c11c26d0b6e64dff2cf52e8975316492 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -1808,7 +1808,7 @@ RUNTIME_FUNCTION(Runtime_DebugOnFunctionCall) {

HandleScope scope(isolate);

DCHECK_EQ(1, args.length());

CONVERT_ARG_HANDLE_CHECKED(JSFunction, fun, 0);

- if (isolate->debug()->last_step_action() >= StepIn) {

+ if (isolate->debug()->step_into_function_call_requested()) {

isolate->debug()->PrepareStepIn(fun);

}

if (isolate->needs_side_effect_check() &&