Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/debug/debug.h

Issue 2758483002: [debugger] tuned StepNext and StepOut at return position (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | test/inspector/protocol-test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/base/atomicops.h" 10 #include "src/base/atomicops.h"
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 // Find the closest source position for a break point for a given position. 483 // Find the closest source position for a break point for a given position.
484 int FindBreakablePosition(Handle<DebugInfo> debug_info, int source_position, 484 int FindBreakablePosition(Handle<DebugInfo> debug_info, int source_position,
485 BreakPositionAlignment alignment); 485 BreakPositionAlignment alignment);
486 // Instrument code to break at break points. 486 // Instrument code to break at break points.
487 void ApplyBreakPoints(Handle<DebugInfo> debug_info); 487 void ApplyBreakPoints(Handle<DebugInfo> debug_info);
488 // Clear code from instrumentation. 488 // Clear code from instrumentation.
489 void ClearBreakPoints(Handle<DebugInfo> debug_info); 489 void ClearBreakPoints(Handle<DebugInfo> debug_info);
490 // Clear all code from instrumentation. 490 // Clear all code from instrumentation.
491 void ClearAllBreakPoints(); 491 void ClearAllBreakPoints();
492 // Instrument a function with one-shots. 492 // Instrument a function with one-shots.
493 void FloodWithOneShot(Handle<SharedFunctionInfo> function); 493 void FloodWithOneShot(Handle<SharedFunctionInfo> function,
494 bool returns_only = false);
494 // Clear all one-shot instrumentations, but restore break points. 495 // Clear all one-shot instrumentations, but restore break points.
495 void ClearOneShot(); 496 void ClearOneShot();
496 497
497 bool IsFrameBlackboxed(JavaScriptFrame* frame); 498 bool IsFrameBlackboxed(JavaScriptFrame* frame);
498 499
499 void ActivateStepOut(StackFrame* frame); 500 void ActivateStepOut(StackFrame* frame);
500 void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info); 501 void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info);
501 MaybeHandle<FixedArray> CheckBreakPoints(Handle<DebugInfo> debug_info, 502 MaybeHandle<FixedArray> CheckBreakPoints(Handle<DebugInfo> debug_info,
502 BreakLocation* location, 503 BreakLocation* location,
503 bool* has_break_points = nullptr); 504 bool* has_break_points = nullptr);
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 559
559 // Current break id. 560 // Current break id.
560 int break_id_; 561 int break_id_;
561 562
562 // Frame id for the frame of the current break. 563 // Frame id for the frame of the current break.
563 StackFrame::Id break_frame_id_; 564 StackFrame::Id break_frame_id_;
564 565
565 // Step action for last step performed. 566 // Step action for last step performed.
566 StepAction last_step_action_; 567 StepAction last_step_action_;
567 568
569 // If set then this function will be ignored in PrepareStepIn call.
dgozman 2017/03/21 23:33:21 If set, next PrepareStepIn will ignore this functi
kozy 2017/03/22 17:19:53 Done.
570 Object* ignore_step_into_function_;
571
572 // If set then we need to repeat StepOut action at return.
573 bool fast_forward_to_return_;
574
568 // Source statement position from last step next action. 575 // Source statement position from last step next action.
569 int last_statement_position_; 576 int last_statement_position_;
570 577
571 // Frame pointer from last step next or step frame action. 578 // Frame pointer from last step next or step frame action.
572 int last_frame_count_; 579 int last_frame_count_;
573 580
574 // Frame pointer of the target frame we want to arrive at. 581 // Frame pointer of the target frame we want to arrive at.
575 int target_frame_count_; 582 int target_frame_count_;
576 583
577 // Value of the accumulator at the point of entering the debugger. 584 // Value of the accumulator at the point of entering the debugger.
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 Handle<Code> code); 806 Handle<Code> code);
800 static bool DebugBreakSlotIsPatched(Address pc); 807 static bool DebugBreakSlotIsPatched(Address pc);
801 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 808 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
802 }; 809 };
803 810
804 811
805 } // namespace internal 812 } // namespace internal
806 } // namespace v8 813 } // namespace v8
807 814
808 #endif // V8_DEBUG_DEBUG_H_ 815 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | test/inspector/protocol-test.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698