Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: content/renderer/media/webrtc_audio_renderer.h

Issue 2758453004: Remove dangling PlayingState pointers in WebRtcAudioRenderer. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_audio_renderer.h
diff --git a/content/renderer/media/webrtc_audio_renderer.h b/content/renderer/media/webrtc_audio_renderer.h
index 1da6863cb2062447c10119f94712a229b24c9e70..4f6508edbcda8313c81d91f28ca19528928f02d9 100644
--- a/content/renderer/media/webrtc_audio_renderer.h
+++ b/content/renderer/media/webrtc_audio_renderer.h
@@ -8,6 +8,7 @@
#include <stdint.h>
#include <map>
+#include <memory>
#include <string>
#include <vector>
@@ -191,7 +192,8 @@ class CONTENT_EXPORT WebRtcAudioRenderer
// sources associated with the |media_stream| based on the collective volume
// of playing renderers.
void OnPlayStateChanged(const blink::WebMediaStream& media_stream,
- PlayingState* state);
+ PlayingState* state,
+ bool playing_state_deleted);
tommi (sloooow) - chröme 2017/03/17 12:44:08 what about including a TODO here to clean this up.
Max Morin 2017/03/17 14:08:03 I put a TODO in OnPlayStateRemoved.
// Updates |sink_params_| and |audio_fifo_| based on |sink_|, and initializes
// |sink_|.
« no previous file with comments | « no previous file | content/renderer/media/webrtc_audio_renderer.cc » ('j') | content/renderer/media/webrtc_audio_renderer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698