Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 275833002: Implement "Copy image" for canvas (chromium side). (Closed)

Created:
6 years, 7 months ago by zino
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement "Copy image" for canvas (chromium side). Many users want to copy the image of <canvas> to clipboard. (like <img>) As well as being useful, The feature is already supported in Firefox and IE. Blink side: https://codereview.chromium.org/270613004/ BUG=369092 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281470

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
zino
Please take a look. Thank you :)
6 years, 7 months ago (2014-05-09 09:30:54 UTC) #1
Justin Novosad
On 2014/05/09 09:30:54, zino wrote: > Please take a look. > > Thank you :) ...
6 years, 7 months ago (2014-05-09 14:25:26 UTC) #2
Avi (use Gerrit)
Huh. So all the stuff you put in already handles it? Well, what's to complain ...
6 years, 7 months ago (2014-05-09 15:09:20 UTC) #3
zino
On 2014/05/09 14:25:26, junov wrote: > On 2014/05/09 09:30:54, zino wrote: > > Please take ...
6 years, 7 months ago (2014-05-09 17:14:07 UTC) #4
zino
@Avi, This CL has already gotten lgtm but it haven't been landed for a long ...
6 years, 5 months ago (2014-07-03 10:46:43 UTC) #5
Avi (use Gerrit)
On 2014/07/03 10:46:43, zino wrote: > @Avi, > > This CL has already gotten lgtm ...
6 years, 5 months ago (2014-07-03 15:23:08 UTC) #6
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 5 months ago (2014-07-05 03:02:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/275833002/20001
6 years, 5 months ago (2014-07-05 03:03:23 UTC) #8
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 5 months ago (2014-07-05 17:50:03 UTC) #9
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 5 months ago (2014-07-05 17:50:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/275833002/20001
6 years, 5 months ago (2014-07-05 17:50:26 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-05 19:10:59 UTC) #12
Message was sent while issue was closed.
Change committed as 281470

Powered by Google App Engine
This is Rietveld 408576698