chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc - Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)

Patch Set: Final feedback addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc ('k') | chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

diff --git a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

index 7238e8e0713fabeeb88a4942c1645e336fc8f0f6..4c3b109d62a6875c44e0cd27ea8bf5c8387acc4b 100644

--- a/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

+++ b/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/media/webrtc/fake_desktop_media_list.h"

#include "chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h"

#include "chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h"

+#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"

#include "components/web_modal/test_web_contents_modal_dialog_host.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -22,6 +23,7 @@

#include "ui/views/controls/button/checkbox.h"

#include "ui/views/controls/tabbed_pane/tabbed_pane.h"

#include "ui/views/test/scoped_views_test_helper.h"

+#include "ui/views/test/test_views_delegate.h"

#include "ui/views/widget/widget.h"

#include "ui/views/window/dialog_client_view.h"

#include "ui/views/window/dialog_delegate.h"

@@ -40,6 +42,8 @@ class DesktopMediaPickerViewsTest : public testing::Test {

~DesktopMediaPickerViewsTest() override {}

void SetUp() override {

+ test_helper_.test_views_delegate()->set_layout_provider(

+ ChromeLayoutProvider::CreateLayoutProvider());

media_lists_[DesktopMediaID::TYPE_SCREEN] = new FakeDesktopMediaList();

media_lists_[DesktopMediaID::TYPE_WINDOW] = new FakeDesktopMediaList();

media_lists_[DesktopMediaID::TYPE_WEB_CONTENTS] =