Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4192)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Final feedback addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
index 8753767fb5612e36f9e78ba5808673ffd545d414..654d52a8fda42a6f82ae65260804a36938ae934a 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
@@ -15,7 +15,7 @@
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils_desktop.h"
#include "chrome/browser/ui/browser_dialogs.h"
-#include "chrome/browser/ui/views/harmony/layout_delegate.h"
+#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/grit/locale_settings.h"
#include "components/bookmarks/browser/bookmark_model.h"
@@ -341,19 +341,18 @@ void BookmarkEditorView::Init() {
}
GridLayout* layout = GridLayout::CreatePanel(this);
- LayoutDelegate* delegate = LayoutDelegate::Get();
+ ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
const int labels_column_set_id = 0;
const int single_column_view_set_id = 1;
const int buttons_column_set_id = 2;
views::ColumnSet* column_set = layout->AddColumnSet(labels_column_set_id);
- column_set->AddColumn(delegate->GetControlLabelGridAlignment(),
+ column_set->AddColumn(provider->GetControlLabelGridAlignment(),
GridLayout::CENTER, 0, GridLayout::USE_PREF, 0, 0);
column_set->AddPaddingColumn(
0,
- delegate->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_HORIZONTAL_SPACING));
+ provider->GetDistanceMetric(views::DISTANCE_RELATED_CONTROL_HORIZONTAL));
column_set->AddColumn(GridLayout::FILL, GridLayout::CENTER, 1,
GridLayout::USE_PREF, 0, 0);
@@ -366,14 +365,12 @@ void BookmarkEditorView::Init() {
GridLayout::USE_PREF, 0, 0);
column_set->AddPaddingColumn(
1,
- delegate->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_HORIZONTAL_SPACING));
+ provider->GetDistanceMetric(views::DISTANCE_RELATED_CONTROL_HORIZONTAL));
column_set->AddColumn(GridLayout::FILL, GridLayout::LEADING, 0,
GridLayout::USE_PREF, 0, 0);
column_set->AddPaddingColumn(
0,
- delegate->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_HORIZONTAL_SPACING));
+ provider->GetDistanceMetric(views::DISTANCE_RELATED_CONTROL_HORIZONTAL));
column_set->AddColumn(GridLayout::FILL, GridLayout::LEADING, 0,
GridLayout::USE_PREF, 0, 0);
column_set->LinkColumnSizes(0, 2, 4, -1);
@@ -392,10 +389,8 @@ void BookmarkEditorView::Init() {
url_tf_->SetAccessibleName(
l10n_util::GetStringUTF16(IDS_BOOKMARK_AX_EDITOR_URL_LABEL));
- layout->AddPaddingRow(
- 0,
- delegate->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_VERTICAL_SPACING));
+ layout->AddPaddingRow(0, provider->GetDistanceMetric(
+ views::DISTANCE_RELATED_CONTROL_VERTICAL));
layout->StartRow(0, labels_column_set_id);
layout->AddView(url_label_);
@@ -403,19 +398,15 @@ void BookmarkEditorView::Init() {
}
if (show_tree_) {
- layout->AddPaddingRow(
- 0,
- delegate->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_VERTICAL_SPACING));
+ layout->AddPaddingRow(0, provider->GetDistanceMetric(
+ views::DISTANCE_RELATED_CONTROL_VERTICAL));
layout->StartRow(1, single_column_view_set_id);
layout->AddView(tree_view_->CreateParentIfNecessary());
}
- if (delegate->UseExtraDialogPadding()) {
- layout->AddPaddingRow(
- 0,
- delegate->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_VERTICAL_SPACING));
+ if (provider->UseExtraDialogPadding()) {
+ layout->AddPaddingRow(0, provider->GetDistanceMetric(
+ views::DISTANCE_RELATED_CONTROL_VERTICAL));
}
if (!show_tree_ || bb_model_->loaded())

Powered by Google App Engine
This is Rietveld 408576698