chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc - Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)

Patch Set: Final feedback addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc ('k') | chrome/browser/ui/views/arc_app_dialog_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

index 57453f871c15c8041f8b4e41b7201dd59edf7fa3..56cd08fd8e1c1197ca970df441775293e229b895 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

@@ -16,7 +16,7 @@

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h"

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h"

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h"

-#include "chrome/browser/ui/views/harmony/layout_delegate.h"

+#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/features.h"

@@ -137,8 +137,8 @@ AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,

views::View* dialog_body_contents = new views::View();

dialog_body_contents->SetLayoutManager(new views::BoxLayout(

views::BoxLayout::kVertical, views::kButtonHEdgeMarginNew,

- LayoutDelegate::Get()->GetMetric(

- LayoutDelegate::Metric::PANEL_CONTENT_MARGIN),

+ ChromeLayoutProvider::Get()->GetDistanceMetric(

+ DISTANCE_PANEL_CONTENT_MARGIN),

views::kUnrelatedControlVerticalSpacing));

dialog_body_contents->AddChildView(new AppInfoSummaryPanel(profile, app));

dialog_body_contents->AddChildView(new AppInfoPermissionsPanel(profile, app));