Broke out layout metric information from ViewsDelegate to LayoutProvider

chrome/test/base/browser_with_test_window_test.h

Index: chrome/test/base/browser_with_test_window_test.h
diff --git a/chrome/test/base/browser_with_test_window_test.h b/chrome/test/base/browser_with_test_window_test.h
index a6d31237dab561cd7ec0cdf38accd934293da4a2..de1d2cfa737397f59c53c0ab4a4c611069e5d2b3 100644
--- a/chrome/test/base/browser_with_test_window_test.h
+++ b/chrome/test/base/browser_with_test_window_test.h
@@ -40,6 +40,9 @@ namespace views {
 class ScopedViewsTestHelper;
 }
 #endif
+namespace views {
+class TestViewsDelegate;
+}
 
 namespace content {
 class NavigationController;
@@ -148,6 +151,8 @@ class BrowserWithTestWindowTest : public testing::Test {
                                  bool hosted_app,
                                  BrowserWindow* browser_window);
 
+  views::TestViewsDelegate* views_delegate();

[Peter Kasting, 2017/04/04 02:08:55]

Nit: This should be defined here or else named CamelCase.

Consider naming this test_views_delegate() instead, as the code which calls it
does so to call methods available in TestViewsDelegate that aren't in
ViewsDelegate (or it could just use ViewsDelegate::Get()), and it was confusing
me trying to read such code as I reviewed this CL (I was thinking, "how are you
calling ViewsDelegate::set_layout_delegate(), that doesn't exist").

[kylix_rd, 2017/04/04 20:28:23]

Renamed to test_views_delegate().
Good point.

[Peter Kasting, 2017/04/05 19:30:10]

That addresses the second concern I had, but not this one: we use
unix_hacker_names() to indicate inlined cheap accessors, so if this is named
that way it should also be inlined.  If for some reason it doesn't make sense to
inline, I'd name it GetTestViewsDelegate() to indicate that.

[kylix_rd, 2017/04/06 16:48:19]

Hmmm. I was looking more for consistency with the other test classes which also
have test_views_delegate().

[Peter Kasting, 2017/04/06 20:05:33]

That's fine, just inline it then :)

The actual function definition is simple enough that inlining seems reasonable.

[kylix_rd, 2017/04/07 14:07:59]

I'll need to verify that including test_views_delegate.h in the header doesn't
cause any other issues. Right now, TestViewsDelegate is forward declared here in
the header and the .cc file includes the full definition.

[kylix_rd, 2017/04/07 18:33:36]

Done.

+
  private:
   // We need to create a MessageLoop, otherwise a bunch of things fails.
   content::TestBrowserThreadBundle thread_bundle_;