Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6830)

Unified Diff: chrome/browser/ui/views/task_manager_view.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Deleted LayoutDelegate and HarmonyLayoutDelegate. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/task_manager_view.cc
diff --git a/chrome/browser/ui/views/task_manager_view.cc b/chrome/browser/ui/views/task_manager_view.cc
index 6d9eafc52b839fb8c271dd91e0645735990f569d..cddeec1b19bb253cd86f092b67fac5ccd4d73e60 100644
--- a/chrome/browser/ui/views/task_manager_view.cc
+++ b/chrome/browser/ui/views/task_manager_view.cc
@@ -17,7 +17,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/task_manager/task_manager_columns.h"
#include "chrome/browser/ui/user_manager.h"
-#include "chrome/browser/ui/views/harmony/layout_delegate.h"
+#include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/chromium_strings.h"
@@ -332,9 +332,10 @@ void TaskManagerView::Init() {
AddChildView(tab_table_parent_);
SetLayoutManager(new views::FillLayout());
+ // TODO: Harmony - review the use of the constants below
Peter Kasting 2017/04/04 02:08:54 Nit: I probably wouldn't add this comment (there a
kylix_rd 2017/04/04 20:28:23 Done.
SetBorder(views::CreateEmptyBorder(
- LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::PANEL_CONTENT_MARGIN),
+ ChromeViewsLayoutDelegate::Get()->GetDistanceMetric(
+ ChromeDistanceMetric::PANEL_CONTENT_MARGIN),
views::kButtonHEdgeMarginNew, 0, views::kButtonHEdgeMarginNew));
table_model_->RetrieveSavedColumnsSettingsAndUpdateTable();

Powered by Google App Engine
This is Rietveld 408576698