Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/ui/views/arc_app_dialog_view.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Fix various unit-tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/arc_app_dialog_view.cc
diff --git a/chrome/browser/ui/views/arc_app_dialog_view.cc b/chrome/browser/ui/views/arc_app_dialog_view.cc
index bdb73fe5a2e66a74e4ef81ea35f6dd0684f0ae43..8e87fd5dab8e7d515ffce458d977c3d44f337293 100644
--- a/chrome/browser/ui/views/arc_app_dialog_view.cc
+++ b/chrome/browser/ui/views/arc_app_dialog_view.cc
@@ -14,7 +14,7 @@
#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
#include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
#include "chrome/browser/ui/native_window_tracker.h"
-#include "chrome/browser/ui/views/harmony/layout_delegate.h"
+#include "chrome/browser/ui/views/harmony/chrome_views_layout_delegate.h"
#include "chrome/grit/generated_resources.h"
#include "components/constrained_window/constrained_window_views.h"
#include "components/strings/grit/components_strings.h"
@@ -138,10 +138,11 @@ ArcAppDialogView::ArcAppDialogView(Profile* profile,
if (parent_)
parent_window_tracker_ = NativeWindowTracker::Create(parent_);
+ // TODO: Harmony - review the use of constants below
Peter Kasting 2017/03/30 00:49:04 Nit: I wouldn't add this TODO for now, as we haven
kylix_rd 2017/03/30 19:34:07 Done.
SetLayoutManager(new views::BoxLayout(
views::BoxLayout::kHorizontal, views::kButtonHEdgeMarginNew,
- LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::PANEL_CONTENT_MARGIN),
+ ChromeViewsLayoutDelegate::Get()->GetDistanceMetric(
+ ChromeDistanceMetric::PANEL_CONTENT_MARGIN),
views::kRelatedControlHorizontalSpacing));
icon_view_ = new FixedBoundarySizeImageView();

Powered by Google App Engine
This is Rietveld 408576698