Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: chrome/browser/ui/views/chrome_views_delegate.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Fix Bookmark and Global error unittests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/chrome_views_delegate.cc
diff --git a/chrome/browser/ui/views/chrome_views_delegate.cc b/chrome/browser/ui/views/chrome_views_delegate.cc
index 9f5c82dc86c4fd8a387099e21c780b3199af7ed9..293b1606079d1275a35c6688fbac2eab266b80ff 100644
--- a/chrome/browser/ui/views/chrome_views_delegate.cc
+++ b/chrome/browser/ui/views/chrome_views_delegate.cc
@@ -57,32 +57,19 @@ PrefService* GetPrefsForWindow(const views::Widget* window) {
return profile->GetPrefs();
}
-ChromeViewsDelegate* views_delegate = nullptr;
+// ChromeViewsDelegate* views_delegate = nullptr;
} // namespace
// ChromeViewsDelegate --------------------------------------------------------
-#if defined(OS_WIN)
-ChromeViewsDelegate::ChromeViewsDelegate()
- : in_autohide_edges_callback_(false), weak_factory_(this) {
-#else
-ChromeViewsDelegate::ChromeViewsDelegate() {
+#if !defined(OS_WIN)
+ChromeViewsDelegate::ChromeViewsDelegate() {}
#endif
- DCHECK(!views_delegate);
- views_delegate = this;
-}
ChromeViewsDelegate::~ChromeViewsDelegate() {
DCHECK_EQ(0u, ref_count_);
-
- DCHECK_EQ(this, views_delegate);
- views_delegate = nullptr;
-}
-
-ChromeViewsDelegate* ChromeViewsDelegate::GetInstance() {
- return views_delegate;
}
void ChromeViewsDelegate::SaveWindowPlacement(const views::Widget* window,
@@ -209,75 +196,6 @@ ChromeViewsDelegate::GetBlockingPoolTaskRunner() {
return content::BrowserThread::GetBlockingPool();
}
-gfx::Insets ChromeViewsDelegate::GetInsetsMetric(
- views::InsetsMetric metric) const {
- const LayoutDelegate* layout_delegate = LayoutDelegate::Get();
- switch (metric) {
- case views::InsetsMetric::DIALOG_BUTTON: {
- const int top = layout_delegate->GetMetric(
- LayoutDelegate::Metric::DIALOG_BUTTON_TOP_SPACING);
- const int margin = layout_delegate->GetMetric(
- LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN);
- return gfx::Insets(top, margin, margin, margin);
- }
- case views::InsetsMetric::DIALOG_FRAME_VIEW: {
- const int top = layout_delegate->GetMetric(
- LayoutDelegate::Metric::PANEL_CONTENT_MARGIN);
- const int side = layout_delegate->GetMetric(
- LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN);
- // Titles are inset at the top and sides, but not at the bottom.
- return gfx::Insets(top, side, 0, side);
- }
- case views::InsetsMetric::BUBBLE_DIALOG:
- return gfx::Insets(layout_delegate->GetMetric(
- LayoutDelegate::Metric::PANEL_CONTENT_MARGIN));
- }
- NOTREACHED();
- return gfx::Insets();
-}
-
-int ChromeViewsDelegate::GetDistanceMetric(views::DistanceMetric metric) const {
- switch (metric) {
- case views::DistanceMetric::CLOSE_BUTTON_MARGIN:
- return LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::DIALOG_CLOSE_BUTTON_MARGIN);
- case views::DistanceMetric::RELATED_BUTTON_HORIZONTAL:
- return LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::RELATED_BUTTON_HORIZONTAL_SPACING);
- case views::DistanceMetric::RELATED_CONTROL_HORIZONTAL:
- return LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_HORIZONTAL_SPACING);
- case views::DistanceMetric::RELATED_CONTROL_VERTICAL:
- return LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::RELATED_CONTROL_VERTICAL_SPACING);
- case views::DistanceMetric::DIALOG_BUTTON_MINIMUM_WIDTH:
- return LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::DIALOG_BUTTON_MINIMUM_WIDTH);
- case views::DistanceMetric::BUTTON_HORIZONTAL_PADDING:
- return LayoutDelegate::Get()->GetMetric(
- LayoutDelegate::Metric::BUTTON_HORIZONTAL_PADDING);
- }
- NOTREACHED();
- return 0;
-}
-
-const views::TypographyProvider& ChromeViewsDelegate::GetTypographyProvider()
- const {
- return LayoutDelegate::Get()->GetTypographyProvider();
-}
-
-int ChromeViewsDelegate::GetDefaultDistanceMetric(
- views::DistanceMetric metric) {
- return views_delegate
- ? views_delegate->InternalGetDefaultDistanceMetric(metric)
- : views::ViewsDelegate::GetInstance()->GetDistanceMetric(metric);
-}
-
-int ChromeViewsDelegate::InternalGetDefaultDistanceMetric(
- views::DistanceMetric metric) const {
- return views::ViewsDelegate::GetDistanceMetric(metric);
-}
-
#if !defined(OS_CHROMEOS)
views::Widget::InitParams::WindowOpacity
ChromeViewsDelegate::GetOpacityForInitParams(

Powered by Google App Engine
This is Rietveld 408576698