Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Side by Side Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: LayoutDelegate -> LayoutProvider Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h" 10 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h"
11 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h" 11 #include "chrome/browser/ui/views/extensions/media_galleries_dialog_views.h"
12 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h" 12 #include "chrome/browser/ui/views/extensions/media_gallery_checkbox_view.h"
13 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
13 #include "components/storage_monitor/storage_info.h" 14 #include "components/storage_monitor/storage_info.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 #include "ui/views/controls/button/checkbox.h" 16 #include "ui/views/controls/button/checkbox.h"
16 #include "ui/views/test/test_views_delegate.h" 17 #include "ui/views/test/test_views_delegate.h"
17 18
18 using ::testing::_; 19 using ::testing::_;
19 using ::testing::AnyNumber; 20 using ::testing::AnyNumber;
20 using ::testing::Mock; 21 using ::testing::Mock;
21 using ::testing::NiceMock; 22 using ::testing::NiceMock;
22 using ::testing::Return; 23 using ::testing::Return;
(...skipping 18 matching lines...) Expand all
41 MediaGalleriesDialogTest() {} 42 MediaGalleriesDialogTest() {}
42 ~MediaGalleriesDialogTest() override {} 43 ~MediaGalleriesDialogTest() override {}
43 void SetUp() override { 44 void SetUp() override {
44 std::vector<base::string16> headers; 45 std::vector<base::string16> headers;
45 headers.push_back(base::string16()); 46 headers.push_back(base::string16());
46 headers.push_back(base::ASCIIToUTF16("header2")); 47 headers.push_back(base::ASCIIToUTF16("header2"));
47 ON_CALL(controller_, GetSectionHeaders()). 48 ON_CALL(controller_, GetSectionHeaders()).
48 WillByDefault(Return(headers)); 49 WillByDefault(Return(headers));
49 EXPECT_CALL(controller_, GetSectionEntries(_)). 50 EXPECT_CALL(controller_, GetSectionEntries(_)).
50 Times(AnyNumber()); 51 Times(AnyNumber());
52 test_views_delegate_.set_layout_provider(
53 ChromeLayoutProvider::CreateLayoutProvider());
51 } 54 }
52 55
53 void TearDown() override { 56 void TearDown() override {
54 Mock::VerifyAndClearExpectations(&controller_); 57 Mock::VerifyAndClearExpectations(&controller_);
55 } 58 }
56 59
57 NiceMock<MediaGalleriesDialogControllerMock>* controller() { 60 NiceMock<MediaGalleriesDialogControllerMock>* controller() {
58 return &controller_; 61 return &controller_;
59 } 62 }
60 63
61 private: 64 private:
62 // TODO(gbillock): Get rid of this mock; make something specialized. 65 // TODO(gbillock): Get rid of this mock; make something specialized.
63 NiceMock<MediaGalleriesDialogControllerMock> controller_; 66 NiceMock<MediaGalleriesDialogControllerMock> controller_;
64 views::TestViewsDelegate views_delegate_; 67 views::TestViewsDelegate test_views_delegate_;
65 68
66 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogTest); 69 DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogTest);
67 }; 70 };
68 71
69 // Tests that checkboxes are initialized according to the contents of 72 // Tests that checkboxes are initialized according to the contents of
70 // permissions in the registry. 73 // permissions in the registry.
71 TEST_F(MediaGalleriesDialogTest, InitializeCheckboxes) { 74 TEST_F(MediaGalleriesDialogTest, InitializeCheckboxes) {
72 MediaGalleriesDialogController::Entries attached_permissions; 75 MediaGalleriesDialogController::Entries attached_permissions;
73 attached_permissions.push_back( 76 attached_permissions.push_back(
74 MediaGalleriesDialogController::Entry(MakePrefInfoForTesting(1), true)); 77 MediaGalleriesDialogController::Entry(MakePrefInfoForTesting(1), true));
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2); 160 MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2);
158 attached_permissions.push_back( 161 attached_permissions.push_back(
159 MediaGalleriesDialogController::Entry(gallery2, true)); 162 MediaGalleriesDialogController::Entry(gallery2, true));
160 dialog.UpdateGalleries(); 163 dialog.UpdateGalleries();
161 EXPECT_EQ(2U, dialog.checkbox_map_.size()); 164 EXPECT_EQ(2U, dialog.checkbox_map_.size());
162 165
163 attached_permissions.pop_back(); 166 attached_permissions.pop_back();
164 dialog.UpdateGalleries(); 167 dialog.UpdateGalleries();
165 EXPECT_EQ(1U, dialog.checkbox_map_.size()); 168 EXPECT_EQ(1U, dialog.checkbox_map_.size());
166 } 169 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698