Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)
Patch Set: Addressed Feedback. Renamed ViewsLayoutDelegate to LayoutDelegate and ChromeViewsLayoutDelegate to … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/first_run/try_chrome_dialog_view.h" 5 #include "chrome/browser/first_run/try_chrome_dialog_view.h"
6 6
7 #include <shellapi.h> 7 #include <shellapi.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 16 matching lines...) Expand all
27 #include "ui/views/background.h" 27 #include "ui/views/background.h"
28 #include "ui/views/controls/button/checkbox.h" 28 #include "ui/views/controls/button/checkbox.h"
29 #include "ui/views/controls/button/image_button.h" 29 #include "ui/views/controls/button/image_button.h"
30 #include "ui/views/controls/button/md_text_button.h" 30 #include "ui/views/controls/button/md_text_button.h"
31 #include "ui/views/controls/button/radio_button.h" 31 #include "ui/views/controls/button/radio_button.h"
32 #include "ui/views/controls/image_view.h" 32 #include "ui/views/controls/image_view.h"
33 #include "ui/views/controls/link.h" 33 #include "ui/views/controls/link.h"
34 #include "ui/views/controls/separator.h" 34 #include "ui/views/controls/separator.h"
35 #include "ui/views/layout/grid_layout.h" 35 #include "ui/views/layout/grid_layout.h"
36 #include "ui/views/layout/layout_constants.h" 36 #include "ui/views/layout/layout_constants.h"
37 #include "ui/views/views_delegate.h" 37 #include "ui/views/layout/layout_delegate.h"
38 #include "ui/views/widget/widget.h" 38 #include "ui/views/widget/widget.h"
39 39
40 namespace { 40 namespace {
41 41
42 const wchar_t kHelpCenterUrl[] = 42 const wchar_t kHelpCenterUrl[] =
43 L"https://support.google.com/chrome/answer/150752"; 43 L"https://support.google.com/chrome/answer/150752";
44 44
45 enum ButtonTags { 45 enum ButtonTags {
46 BT_NONE, 46 BT_NONE,
47 BT_CLOSE_BUTTON, 47 BT_CLOSE_BUTTON,
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 128 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing);
129 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1, 129 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
130 views::GridLayout::USE_PREF, 0, 0); 130 views::GridLayout::USE_PREF, 0, 0);
131 131
132 // Fourth row: [pad][pad][button][pad][button]. 132 // Fourth row: [pad][pad][button][pad][button].
133 columns = layout->AddColumnSet(3); 133 columns = layout->AddColumnSet(3);
134 columns->AddPaddingColumn(0, icon_size.width()); 134 columns->AddPaddingColumn(0, icon_size.width());
135 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0, 135 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0,
136 views::GridLayout::USE_PREF, 0, 0); 136 views::GridLayout::USE_PREF, 0, 0);
137 columns->AddPaddingColumn( 137 columns->AddPaddingColumn(
138 0, views::ViewsDelegate::GetInstance()->GetDistanceMetric( 138 0, views::LayoutDelegate::Get()->GetDistanceMetric(
139 views::DistanceMetric::RELATED_BUTTON_HORIZONTAL)); 139 views::DistanceMetric::RELATED_BUTTON_HORIZONTAL));
140 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0, 140 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 0,
141 views::GridLayout::USE_PREF, 0, 0); 141 views::GridLayout::USE_PREF, 0, 0);
142 142
143 // Fifth row: [pad][pad][link]. 143 // Fifth row: [pad][pad][link].
144 columns = layout->AddColumnSet(4); 144 columns = layout->AddColumnSet(4);
145 columns->AddPaddingColumn(0, icon_size.width()); 145 columns->AddPaddingColumn(0, icon_size.width());
146 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 146 columns->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing);
147 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1, 147 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL, 1,
148 views::GridLayout::USE_PREF, 0, 0); 148 views::GridLayout::USE_PREF, 0, 0);
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 result_ = TRY_CHROME_AS_DEFAULT; 361 result_ = TRY_CHROME_AS_DEFAULT;
362 } 362 }
363 363
364 popup_->Close(); 364 popup_->Close();
365 base::MessageLoop::current()->QuitWhenIdle(); 365 base::MessageLoop::current()->QuitWhenIdle();
366 } 366 }
367 367
368 void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) { 368 void TryChromeDialogView::LinkClicked(views::Link* source, int event_flags) {
369 ::ShellExecuteW(NULL, L"open", kHelpCenterUrl, NULL, NULL, SW_SHOW); 369 ::ShellExecuteW(NULL, L"open", kHelpCenterUrl, NULL, NULL, SW_SHOW);
370 } 370 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698