chrome/browser/chromeos/options/DEPS - Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/options/DEPS

Issue 2758323002: Broke out layout metric information from ViewsDelegate to LayoutProvider (Closed)

Patch Set: Addressed Feedback. Renamed ViewsLayoutDelegate to LayoutDelegate and ChromeViewsLayoutDelegate to … Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # TODO(xdai): Remove these rules after bugs 687340 and 687349 are fixed.	2 # TODO(xdai): Remove this rule after bug 687340 is fixed.

3 "!chrome/browser/ui/views/harmony/layout_delegate.h",	3 "!chrome/browser/ui/views/layout_utils.h",

4 ]	4 ]

5	5
	kylix_rd 2017/04/04 20:50:03 I have a patch that will remove this file entirely I have a patch that will remove this file entirely. When I merged, the layout_utils.* files were removed and the functionality merged into the GridLayout class from ui/views/layout.
OLD	NEW

« no previous file with comments | « ash/test/ash_test_helper.cc ('k') | chrome/browser/chromeos/options/vpn_config_view.cc » ('j') | no next file with comments »